From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: swsusp_restore crap
Date: Tue, 15 Mar 2005 14:24:29 +1100 [thread overview]
Message-ID: <1110857069.29123.5.camel@gaston> (raw)
Hi Pavel !
Please kill that swsusp_restore() call that itself calls
flush_tlb_global(), it's junk. First, the flush_tlb_global() thing is
arch specific, and that's all swsusp_restore() does. Then, the asm just
calls this before returning to C code, so it makes no sense to have a
hook there. The x86 asm can have it's own call to some arch stuff if it
wants or just do the tlb flush in asm...
Ben.
next reply other threads:[~2005-03-15 3:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-15 3:24 Benjamin Herrenschmidt [this message]
2005-03-15 3:31 ` Benjamin Herrenschmidt
2005-03-15 11:03 ` Pavel Machek
2005-03-15 11:51 ` Rafael J. Wysocki
2005-03-15 12:02 ` Pavel Machek
2005-03-15 13:27 ` Benjamin Herrenschmidt
2005-03-15 14:55 ` Rafael J. Wysocki
2005-03-15 20:46 ` Pavel Machek
2005-03-15 22:23 ` Rafael J. Wysocki
2005-03-15 23:39 ` Pavel Machek
2005-03-16 0:08 ` Rafael J. Wysocki
2005-03-15 13:26 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1110857069.29123.5.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®