From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Pavel Machek <pavel@ucw.cz>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: swsusp_restore crap
Date: Wed, 16 Mar 2005 00:26:44 +1100 [thread overview]
Message-ID: <1110893204.24296.6.camel@gaston> (raw)
In-Reply-To: <200503151251.01109.rjw@sisk.pl>
> It breaks compilation on i386 either, because nr_copy_pages_check
> is static in swsusp.c. May I propose the following patch instead (tested on
> x86-64 and i386)?
>
> Greets,
> Rafael
>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
>
> diff -Nrup linux-2.6.11-bk10-a/arch/i386/power/cpu.c linux-2.6.11-bk10-b/arch/i386/power/cpu.c
> --- linux-2.6.11-bk10-a/arch/i386/power/cpu.c 2005-03-15 09:20:53.000000000 +0100
> +++ linux-2.6.11-bk10-b/arch/i386/power/cpu.c 2005-03-15 12:16:57.000000000 +0100
> @@ -147,6 +147,15 @@ void restore_processor_state(void)
> __restore_processor_state(&saved_context);
> }
>
> +asmlinkage int __swsusp_flush_tlb(void)
> +{
> + swsusp_restore_check();
> +
Do we really need that check there ? Can't it be moved elsewhere ?
Ben.
prev parent reply other threads:[~2005-03-15 13:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-15 3:24 Benjamin Herrenschmidt
2005-03-15 3:31 ` Benjamin Herrenschmidt
2005-03-15 11:03 ` Pavel Machek
2005-03-15 11:51 ` Rafael J. Wysocki
2005-03-15 12:02 ` Pavel Machek
2005-03-15 13:27 ` Benjamin Herrenschmidt
2005-03-15 14:55 ` Rafael J. Wysocki
2005-03-15 20:46 ` Pavel Machek
2005-03-15 22:23 ` Rafael J. Wysocki
2005-03-15 23:39 ` Pavel Machek
2005-03-16 0:08 ` Rafael J. Wysocki
2005-03-15 13:26 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1110893204.24296.6.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®