From: James Bottomley <James.Bottomley@SteelEye.com>
To: Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH] ia64 kernel fails to link because of PCI MSI quirk
Date: Tue, 15 Mar 2005 10:50:10 -0600 [thread overview]
Message-ID: <1110905410.5685.15.camel@mulgrave> (raw)
The problem is that the MSI code has an unconditional dependency on
pci_msi_quirk. However, the quirk and the variable are only defined if
CONFIG_X86_IO_APIC is defined, which it never is on ia64.
The solution is to make the variable global and unconditional.
James
===== drivers/pci/quirks.c 1.72 vs edited =====
--- 1.72/drivers/pci/quirks.c 2005-03-10 02:38:25 -06:00
+++ edited/drivers/pci/quirks.c 2005-03-15 10:25:43 -06:00
@@ -19,6 +19,8 @@
#include <linux/init.h>
#include <linux/delay.h>
+int pci_msi_quirk = 0;
+
#undef DEBUG
/* Deal with broken BIOS'es that neglect to enable passive release,
@@ -428,8 +430,6 @@
sis_apic_bug = 1;
}
DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_SI, PCI_ANY_ID,
quirk_ioapic_rmw );
-
-int pci_msi_quirk;
#define AMD8131_revA0 0x01
#define AMD8131_revB0 0x11
next reply other threads:[~2005-03-15 16:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-15 16:50 James Bottomley [this message]
2005-03-15 19:54 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1110905410.5685.15.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®