From: Andrew Morton <akpm@osdl.org>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ia64 kernel fails to link because of PCI MSI quirk
Date: Tue, 15 Mar 2005 11:54:51 -0800 [thread overview]
Message-ID: <20050315115451.50dbf001.akpm@osdl.org> (raw)
In-Reply-To: <1110905410.5685.15.camel@mulgrave>
James Bottomley <James.Bottomley@SteelEye.com> wrote:
>
> The problem is that the MSI code has an unconditional dependency on
> pci_msi_quirk. However, the quirk and the variable are only defined if
> CONFIG_X86_IO_APIC is defined, which it never is on ia64.
Yes, I hit that as well.
> The solution is to make the variable global and unconditional.
I fixed it differently:
--- 25/drivers/pci/pci.h~ia64-msi-build-fix Sat Mar 12 18:13:37 2005
+++ 25-akpm/drivers/pci/pci.h Sat Mar 12 18:14:23 2005
@@ -64,8 +64,13 @@ extern void pci_remove_legacy_files(stru
/* Lock for read/write access to pci device and bus lists */
extern spinlock_t pci_bus_lock;
-extern int pcie_mch_quirk;
+#ifdef CONFIG_X86_IO_APIC
extern int pci_msi_quirk;
+#else
+#define pci_msi_quirk 0
+#endif
+
+extern int pcie_mch_quirk;
extern struct device_attribute pci_dev_attrs[];
extern struct class_device_attribute class_device_attr_cpuaffinity;
_
prev parent reply other threads:[~2005-03-15 20:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-15 16:50 James Bottomley
2005-03-15 19:54 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050315115451.50dbf001.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=James.Bottomley@SteelEye.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®