From: john stultz <johnstul@us.ibm.com>
To: Pavel Machek <pavel@suse.cz>
Cc: lkml <linux-kernel@vger.kernel.org>,
Tim Schmielau <tim@physik3.uni-rostock.de>,
George Anzinger <george@mvista.com>,
albert@users.sourceforge.net,
Ulrich Windl <ulrich.windl@rz.uni-regensburg.de>,
Christoph Lameter <clameter@sgi.com>,
Dominik Brodowski <linux@dominikbrodowski.de>,
David Mosberger <davidm@hpl.hp.com>, Andi Kleen <ak@suse.de>,
paulus@samba.org, schwidefsky@de.ibm.com,
keith maanthey <kmannth@us.ibm.com>,
Patricia Gaughen <gone@us.ibm.com>,
Chris McDermott <lcm@us.ibm.com>, Max Asbock <masbock@us.ibm.com>,
mahuja@us.ibm.com, Nishanth Aravamudan <nacc@us.ibm.com>,
Darren Hart <darren@dvhart.com>,
"Darrick J. Wong" <djwong@us.ibm.com>,
Anton Blanchard <anton@samba.org>,
donf@us.ibm.com
Subject: Re: [RFC][PATCH] new timeofday arch specific hooks (v. A3)
Date: Tue, 15 Mar 2005 17:44:57 -0800 [thread overview]
Message-ID: <1110937497.30498.504.camel@cog.beaverton.ibm.com> (raw)
In-Reply-To: <20050315234425.GH21292@elf.ucw.cz>
On Wed, 2005-03-16 at 00:44 +0100, Pavel Machek wrote:
> On Út 15-03-05 15:42:09, john stultz wrote:
> > On Tue, 2005-03-15 at 23:59 +0100, Pavel Machek wrote:
> > > > diff -Nru a/arch/i386/kernel/apm.c b/arch/i386/kernel/apm.c
> > > > --- a/arch/i386/kernel/apm.c 2005-03-11 17:02:30 -08:00
> > > > +++ b/arch/i386/kernel/apm.c 2005-03-11 17:02:30 -08:00
> > > > @@ -224,6 +224,7 @@
> > > > #include <linux/smp_lock.h>
> > > > #include <linux/dmi.h>
> > > > #include <linux/suspend.h>
> > > > +#include <linux/timeofday.h>
> > > >
> > > > #include <asm/system.h>
> > > > #include <asm/uaccess.h>
> > > > @@ -1204,6 +1205,7 @@
> > > > device_suspend(PMSG_SUSPEND);
> > > > device_power_down(PMSG_SUSPEND);
> > > >
> > > > + timeofday_suspend_hook();
> > > > /* serialize with the timer interrupt */
> > > > write_seqlock_irq(&xtime_lock);
> > > >
> > >
> > > Could you just register timeofday subsystem as a system device? Then
> > > device_power_down will call you automagically..... And you'll not have
> > > to modify apm, acpi, swsusp, ppc suspend, arm suspend, ...
> >
> > That may very well be the right way to go. At the moment I'm just very
> > hesitant of making any user-visible changes.
> >
> > What is the impact if a new system device name is created and then I
> > later change it? How stable is that interface supposed to be?
>
> Changing its name is okay... your device probably will not have any
> user-accessible controls, right?
Well, at some point I want to have some way for the user to be able to
select which timesource they want to be used. Similar to the current
"clock=" boot option override, there would be some sort of sysfs
timesource entry that users could "echo tsc" or whatever into in order
to force the system to use the tsc timesource at runtime.
This however would be separate from the timeofday suspend/resume hooks,
so its probably not an issue. Let me know if I'm wrong.
thanks!
-john
next prev parent reply other threads:[~2005-03-16 1:45 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-12 1:24 [RFC][PATCH] new timeofday core subsystem " john stultz
2005-03-12 1:25 ` [RFC][PATCH] new timeofday arch specific hooks " john stultz
2005-03-12 1:26 ` [RFC][PATCH] new timeofday arch specific timesource drivers " john stultz
2005-03-12 5:52 ` [RFC][PATCH] new timeofday arch specific hooks " Benjamin Herrenschmidt
2005-03-14 18:09 ` john stultz
2005-03-15 22:59 ` Pavel Machek
2005-03-15 23:42 ` john stultz
2005-03-15 23:44 ` Pavel Machek
2005-03-16 1:44 ` john stultz [this message]
2005-03-16 10:53 ` Pavel Machek
2005-03-13 0:49 ` [RFC][PATCH] new timeofday core subsystem " Matt Mackall
2005-03-13 1:46 ` Andreas Schwab
2005-03-14 18:42 ` john stultz
2005-03-14 19:29 ` Matt Mackall
2005-03-14 19:43 ` john stultz
2005-03-14 19:51 ` Matt Mackall
2005-03-14 20:04 ` john stultz
2005-03-14 20:27 ` Matt Mackall
2005-03-15 0:01 ` Christoph Lameter
2005-03-15 2:16 ` Albert Cahalan
2005-03-15 3:22 ` Christoph Lameter
2005-03-15 15:23 ` Albert Cahalan
2005-03-15 15:52 ` Chris Friesen
2005-03-17 16:55 ` Russell King
2005-03-17 19:44 ` Albert Cahalan
2005-03-17 20:28 ` Russell King
2005-03-15 0:28 ` Christoph Lameter
2005-03-15 0:43 ` john stultz
2005-03-14 23:40 ` George Anzinger
2005-03-15 1:11 ` [topic change] jiffies as a time value john stultz
2005-03-15 23:01 ` George Anzinger
2005-03-16 3:57 ` john stultz
2005-03-15 0:07 ` [RFC][PATCH] new timeofday core subsystem (v. A3) Christoph Lameter
2005-03-15 5:37 ` Christoph Lameter
2005-03-15 18:25 ` john stultz
2005-03-15 22:08 ` George Anzinger
2005-03-17 8:15 ` Ulrich Windl
2005-03-15 6:09 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1110937497.30498.504.camel@cog.beaverton.ibm.com \
--to=johnstul@us.ibm.com \
--cc=ak@suse.de \
--cc=albert@users.sourceforge.net \
--cc=anton@samba.org \
--cc=clameter@sgi.com \
--cc=darren@dvhart.com \
--cc=davidm@hpl.hp.com \
--cc=djwong@us.ibm.com \
--cc=donf@us.ibm.com \
--cc=george@mvista.com \
--cc=gone@us.ibm.com \
--cc=kmannth@us.ibm.com \
--cc=lcm@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.de \
--cc=mahuja@us.ibm.com \
--cc=masbock@us.ibm.com \
--cc=nacc@us.ibm.com \
--cc=paulus@samba.org \
--cc=pavel@suse.cz \
--cc=schwidefsky@de.ibm.com \
--cc=tim@physik3.uni-rostock.de \
--cc=ulrich.windl@rz.uni-regensburg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®