mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Li Shaohua <shaohua.li@intel.com>
To: Zwane Mwaikambo <zwane@arm.linux.org.uk>
Cc: lkml <linux-kernel@vger.kernel.org>,
	ACPI-DEV <acpi-devel@lists.sourceforge.net>,
	Len Brown <len.brown@intel.com>, Pavel Machek <pavel@suse.cz>
Subject: Re: [RFC 5/6]clean cpu state after hotremove CPU
Date: Tue, 05 Apr 2005 09:06:34 +0800	[thread overview]
Message-ID: <1112663194.17861.12.camel@sli10-desk.sh.intel.com> (raw)
In-Reply-To: <Pine.LNX.4.61.0504041242420.30273@montezuma.fsmlabs.com>

On Tue, 2005-04-05 at 03:11, Zwane Mwaikambo wrote:
> On Mon, 4 Apr 2005, Li Shaohua wrote:
> 
> > Clean up all CPU states including its runqueue and idle thread, 
> > so we can use boot time code without any changes.
> > Note this makes /sys/devices/system/cpu/cpux/online unworkable.
> >  
> >  #ifdef CONFIG_HOTPLUG_CPU
> >  #include <asm/nmi.h>
> > +
> > +#ifdef CONFIG_STR_SMP
> > +extern void cpu_exit_clear(int);
> > +#endif
> 
> Perhaps change that ifdef to denote something which clearly shows that its 
> physical hotplug as we'll need this for other users too.
Ok.

> > +#ifdef CONFIG_STR_SMP
> > +extern void do_exit_idle(void);
> > +extern void cpu_uninit(void);
> > +void cpu_exit_clear(int cpu)
> > +{
> > +	int sibling;
> > +	cpucount --;
> 
> Is that protected by the cpu_control semaphore?
cpu_exit_clear is called before the dead CPU ack CPU_DEAD, so it's
finished before __cpu_die returns, which is protected by cpu_control.
Maybe I should add comments for it.

Thanks,
Shaohua


      reply	other threads:[~2005-04-05  1:09 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-04  2:07 Li Shaohua
2005-04-04  5:28 ` Nathan Lynch
2005-04-04  5:42   ` [ACPI] " Li Shaohua
2005-04-04 15:33     ` Nathan Lynch
2005-04-04 22:14       ` Nigel Cunningham
2005-04-04 22:46         ` Nathan Lynch
2005-04-04 22:56           ` Nigel Cunningham
2005-04-04 22:56           ` Ashok Raj
2005-04-05  1:55       ` Li Shaohua
2005-04-06  4:28         ` Nathan Lynch
2005-04-05  9:00       ` Li Shaohua
2005-04-04 19:11 ` Zwane Mwaikambo
2005-04-05  1:06   ` Li Shaohua [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1112663194.17861.12.camel@sli10-desk.sh.intel.com \
    --to=shaohua.li@intel.com \
    --cc=acpi-devel@lists.sourceforge.net \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@suse.cz \
    --cc=zwane@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®