From: Li Shaohua <shaohua.li@intel.com>
To: Nathan Lynch <ntl@pobox.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
ACPI-DEV <acpi-devel@lists.sourceforge.net>,
Zwane Mwaikambo <zwane@linuxpower.ca>,
Len Brown <len.brown@intel.com>, Pavel Machek <pavel@suse.cz>
Subject: Re: [ACPI] Re: [RFC 5/6]clean cpu state after hotremove CPU
Date: Tue, 05 Apr 2005 09:55:06 +0800 [thread overview]
Message-ID: <1112666106.17861.62.camel@sli10-desk.sh.intel.com> (raw)
In-Reply-To: <20050404153345.GC3611@otto>
Hi,
On Mon, 2005-04-04 at 23:33, Nathan Lynch wrote:
>
> I'd say fix the smpboot code so that it doesn't create new idle tasks
> except during boot.
I'd like the the CPU hotremove case just likes the case that CPU isn't
boot. A non-boot CPU hasn't a idle thread. But you may think it's not
worthy doing. Anyway, I will keep the idle thread in a updated patch
like what you said.
> > > We've been
> > > doing cpu removal on ppc64 logical partitions for a while and never
> > > needed to do anything like this.
> > Did it remove idle thread? or dead cpu is in a busy loop of idle?
>
> Neither. The cpu is definitely offline, but there is no reason to
> free the idle thread.
>
> >
> > > Maybe idle_task_exit would suffice?
> > idle_task_exit seems just drop mm. We need destroy the idle task for
> > physical CPU hotplug, right?
>
> No.
>
> > >
> > > I don't understand the need for this, either. The existing cpu
> > > hotplug notifier in the scheduler takes care of initializing the sched
> > > domains and groups appropriately for online/offline events; why do you
> > > need to touch the runqueue structures?
> > If a CPU is physically hotremoved from the system, shouldn't we clean
> > its runqueue?
>
> No. It should make zero difference to the scheduler whether the "play
> dead" cpu hotplug or "physical" hotplug is being used.
Keeping some fields like 'cpu_load' are meanless for a hotadded CPU to
me. Just ignore them?
Thanks,
Shaohua
next prev parent reply other threads:[~2005-04-05 1:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-04 2:07 Li Shaohua
2005-04-04 5:28 ` Nathan Lynch
2005-04-04 5:42 ` [ACPI] " Li Shaohua
2005-04-04 15:33 ` Nathan Lynch
2005-04-04 22:14 ` Nigel Cunningham
2005-04-04 22:46 ` Nathan Lynch
2005-04-04 22:56 ` Nigel Cunningham
2005-04-04 22:56 ` Ashok Raj
2005-04-05 1:55 ` Li Shaohua [this message]
2005-04-06 4:28 ` Nathan Lynch
2005-04-05 9:00 ` Li Shaohua
2005-04-04 19:11 ` Zwane Mwaikambo
2005-04-05 1:06 ` Li Shaohua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1112666106.17861.62.camel@sli10-desk.sh.intel.com \
--to=shaohua.li@intel.com \
--cc=acpi-devel@lists.sourceforge.net \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ntl@pobox.com \
--cc=pavel@suse.cz \
--cc=zwane@linuxpower.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®