mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjan@infradead.org>
To: Dave Jones <davej@redhat.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: tickle nmi watchdog whilst doing serial writes.
Date: Fri, 13 May 2005 21:14:52 +0200	[thread overview]
Message-ID: <1116011692.6694.19.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <20050513184806.GA24166@redhat.com>

On Fri, 2005-05-13 at 14:48 -0400, Dave Jones wrote:
>  	if (up->port.flags & UPF_CONS_FLOW) {
>  		tmout = 1000000;
>  		while (--tmout &&
> -		       ((serial_in(up, UART_MSR) & UART_MSR_CTS) == 0))
> +		       ((serial_in(up, UART_MSR) & UART_MSR_CTS) == 0)) {
>  			udelay(1);
> +			touch_nmi_watchdog();
> +		}
>  	}
>  }
>  
> 
> We *could* tickle it less often, but given we're busy waiting anyway
> it probably doesnt make sense to not favour the more simple approach.
> Hmm, maybe we want a cpu_relax() in there too. opinions?

udelay() includes cpu_relax() already so that is futile.

However.. this is a hack. Do we really need to do busy waiting here for
this long??



  reply	other threads:[~2005-05-13 19:20 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-13 18:48 Dave Jones
2005-05-13 19:14 ` Arjan van de Ven [this message]
2005-05-13 19:23   ` Dave Jones
2005-05-13 19:37   ` Russell King
2005-05-14  6:43 ` Andrew Morton
2005-05-14  6:57   ` Dave Jones
2005-05-14  7:07     ` Andrew Morton
2005-05-14 10:31       ` Ed Tomlinson
2005-05-14 10:53         ` Alexander Nyberg
2005-05-15 11:40           ` Andi Kleen
2005-05-14 10:53         ` Ed Tomlinson
2005-05-15 11:38 ` Andi Kleen
2005-05-15 12:07   ` Russell King
2005-05-15 12:20     ` Andi Kleen
2005-05-15 14:01       ` Russell King
2005-05-15 14:03         ` Andi Kleen
2005-05-19  0:24       ` George Anzinger
2005-05-19  7:33         ` Russell King
2005-05-23 20:20           ` Bill Davidsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1116011692.6694.19.camel@laptopd505.fenrus.org \
    --to=arjan@infradead.org \
    --cc=akpm@osdl.org \
    --cc=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®