From: Arjan van de Ven <arjan@infradead.org>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: davem@davemloft.net
Subject: Re: [CRYPTO]: Only reschedule if !in_atomic()
Date: Tue, 24 May 2005 08:40:45 +0200 [thread overview]
Message-ID: <1116916845.6280.8.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <200505232300.j4NN07lE012726@hera.kernel.org>
> - if (!in_softirq())
> + if (!in_atomic())
> cond_resched();
this looks wrong. in_atomic() isn't doing what I think you think it
does; for one it doesn't get set inside spinlock regions (unless preempt
is enabled)
prev parent reply other threads:[~2005-05-24 6:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200505232300.j4NN07lE012726@hera.kernel.org>
2005-05-23 23:28 ` Andrew Morton
2005-05-23 23:58 ` Benjamin Herrenschmidt
2005-05-24 0:24 ` Andrew Morton
2005-05-24 2:21 ` Herbert Xu
2005-05-24 2:31 ` Andrew Morton
2005-05-24 2:43 ` Herbert Xu
2005-05-24 3:20 ` James Morris
2005-05-24 3:50 ` Herbert Xu
2005-05-24 13:32 ` Bill Davidsen
[not found] ` <20050523.193612.08320356.davem@davemloft.net>
2005-05-24 3:47 ` Herbert Xu
2005-05-24 6:40 ` Arjan van de Ven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1116916845.6280.8.camel@laptopd505.fenrus.org \
--to=arjan@infradead.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®