mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Len Brown <lenb@toshiba.hsd1.ma.comcast.net>
Cc: torvalds@osdl.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	acpi-devel@lists.sourceforge.net, bjorn.helgaas@hp.com
Subject: Re: [ACPI] [PATCH] VIA IRQ quirk for 2.6.12-rc5
Date: Fri, 27 May 2005 11:09:17 +0100	[thread overview]
Message-ID: <1117188546.5730.175.camel@localhost.localdomain> (raw)
In-Reply-To: <20050527082150.GA24428@toshiba.hsd1.ma.comcast.net>

On Gwe, 2005-05-27 at 09:21, Len Brown wrote:
> Delete quirk_via_bridge(), restore quirk_via_irqpic() --
> but now improved to be invoked upon device ENABLE, and
> now only for VIA devices -- not all devices behind VIA bridges.

Properly you should apply the fixup to all VBUS devices. I've not seen a
clean way to identify which devices fall into that category but there
are public 
data sheets for many of the chips.

> +		printk(KERN_INFO "PCI: Via PIC IRQ fixup for %s, from %d to %d\n",
> +			pci_name(dev), irq, new_irq);
> +		udelay(15);	/* unknown if delay really needed */
> +		pci_write_config_byte(dev, PCI_INTERRUPT_LINE, new_irq);

It isn't


  parent reply	other threads:[~2005-05-27 10:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-27  8:21 Len Brown
2005-05-27  8:53 ` [PATCH] ACPI build fix " Len Brown
2005-05-27 10:48   ` Alexander Nyberg
2005-05-27 15:27   ` Linus Torvalds
2005-05-27 10:09 ` Alan Cox [this message]
2005-06-22 16:17   ` [ACPI] [PATCH] VIA IRQ quirk " Bjorn Helgaas
2005-05-27 10:27 ` Alexander Nyberg
2005-05-27 15:47 ` [ACPI] " Sergio Monteiro Basto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1117188546.5730.175.camel@localhost.localdomain \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=acpi-devel@lists.sourceforge.net \
    --cc=bjorn.helgaas@hp.com \
    --cc=lenb@toshiba.hsd1.ma.comcast.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®