mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@osdl.org>
To: Len Brown <lenb@toshiba.hsd1.ma.comcast.net>
Cc: acpi-devel@lists.sourceforge.net,
	Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Alexander Nyberg <alexn@telia.com>
Subject: Re: [PATCH] ACPI build fix for 2.6.12-rc5
Date: Fri, 27 May 2005 08:27:11 -0700 (PDT)	[thread overview]
Message-ID: <Pine.LNX.4.58.0505270815330.17402@ppc970.osdl.org> (raw)
In-Reply-To: <20050527085326.GA29767@toshiba.hsd1.ma.comcast.net>



On Fri, 27 May 2005, Len Brown wrote:
>
> Linus,
> Please apply this CONFIG_ACPI=n build fix to 2.6.12-rc5

Done.

Just a quick note about the Subject line, though (and this is not 
actually particular to Len at all, it's the second email on this that I 
send out just today ;)..

Since my automated tools will take the Subject line as the changelog
entry, and in fact it gets special treatment and ends up being in
shortlogs and in the gitweb summary pages etc, I like it when the Subject
line is "clean" in the sense that it makes sense in that context.

In particular, it's good for _me_ to know that a patch is against a
certain release (and not a "-mm" tree for example), so I certainly don't
mind seeing the the patch is for "2.6.12-rc5". But once it is in the tree,
that versioning information is pointless, and sometimes even wrong (ie
maybe I ended up actually applying the patch only after I released the
next kernel, and now that very public comment just looks strange).

So unless the version is literally important for the patch itself (ie, it 
might _be_ about the version numbers in the Makefile, and you send in a 
patch that changes the all-important NAME field of a particular release), 
I actually much prefer to see these "meta-comments" inside the [] in the 
Subject line, which automatically gets pruned off by the scripts.

IOW, something like this:

	[PATCH -rc5] ACPI build fix

works well (usually the major release is obvious, which is why I shorted 
it to just that part, but it's all up to you at that point: it will be 
peeled off and just replaced with [PATCH] by the scripts).

So in general, you can have small messages for the patch recipient in
there, but don't go overboard. If it's longer than twenty characters, it 
will usually mean that the _actual_ subject line may not show fully in my 
mail index, of course..

			Linus

  parent reply	other threads:[~2005-05-27 15:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-27  8:21 [PATCH] VIA IRQ quirk " Len Brown
2005-05-27  8:53 ` [PATCH] ACPI build fix " Len Brown
2005-05-27 10:48   ` Alexander Nyberg
2005-05-27 15:27   ` Linus Torvalds [this message]
2005-05-27 10:09 ` [ACPI] [PATCH] VIA IRQ quirk " Alan Cox
2005-06-22 16:17   ` Bjorn Helgaas
2005-05-27 10:27 ` Alexander Nyberg
2005-05-27 15:47 ` [ACPI] " Sergio Monteiro Basto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.58.0505270815330.17402@ppc970.osdl.org \
    --to=torvalds@osdl.org \
    --cc=acpi-devel@lists.sourceforge.net \
    --cc=alexn@telia.com \
    --cc=lenb@toshiba.hsd1.ma.comcast.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®