From: David Howells <dhowells@redhat.com>
To: Michal Marek <mmarek@suse.cz>
Cc: dhowells@redhat.com, rusty@rustcorp.com.au,
keyrings@linux-nfs.org, dmitry.kasatkin@gmail.com,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org
Subject: Re: [PATCH 4/5] MODSIGN: Provide a utility to append a PKCS#7 signature to a module [ver #3]
Date: Fri, 01 May 2015 14:26:01 +0100 [thread overview]
Message-ID: <11177.1430486761@warthog.procyon.org.uk> (raw)
In-Reply-To: <54EDCB9E.4080602@suse.cz>
Michal Marek <mmarek@suse.cz> wrote:
> > + ERR(asprintf(&dest_name, "%s.~signed~", module_name) < 0,
> > + "asprintf");
> > + replace_orig = true;
> > + }
> > +
> > + ERR_load_crypto_strings();
> > + ERR_clear_error();
>
> The error queue initialization should be done before the first use of
> the ERR() macro. Or the asprintf check should be open-coded, because it
> has nothing to do with openssl.
Good point.
David
next prev parent reply other threads:[~2015-05-01 13:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-06 14:58 [PATCH 0/5] MODSIGN: Use PKCS#7 for module signatures " David Howells
2015-02-06 14:58 ` [PATCH 1/5] X.509: Extract both parts of the AuthorityKeyIdentifier " David Howells
2015-02-06 14:58 ` [PATCH 2/5] X.509: Support X.509 lookup by Issuer+Serial form " David Howells
2015-02-06 14:59 ` [PATCH 3/5] PKCS#7: Allow detached data to be supplied for signature checking purposes " David Howells
2015-02-06 14:59 ` [PATCH 4/5] MODSIGN: Provide a utility to append a PKCS#7 signature to a module " David Howells
2015-02-25 13:18 ` Michal Marek
2015-05-01 13:26 ` David Howells [this message]
2015-02-06 14:59 ` [PATCH 5/5] MODSIGN: Use PKCS#7 messages as module signatures " David Howells
2015-02-25 13:16 ` [PATCH 0/5] MODSIGN: Use PKCS#7 for " Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11177.1430486761@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=dmitry.kasatkin@gmail.com \
--cc=keyrings@linux-nfs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®