TPM on Thinkpad T43

TPM on Thinkpad T43

[Jens Taprogge]

Hello Kylie,

I have followed your discussion on LKML titled "TPM on IBM thinkcenter
S51".  I seem to have a very similar problem with the TPM in a T43
laptop.

I added the additional PCI IDs but that is not enough to make the driver
detect the chip.  Additionally the value of NSC_SID_INDEX is 0xFF
instead of 0xFE. 

Changing that in the driver gives the following debug output:
	tpm_nsc 0000:00:1f.0: NSC TPM detected
	tpm_nsc 0000:00:1f.0: NSC LDN 0xff, SID 0xff, SRID 0xff
	tpm_nsc 0000:00:1f.0: NSC SIOCF1 0xff SIOCF5 0xff SIOCF6 0xff SIOCF8 0xff
	tpm_nsc 0000:00:1f.0: NSC IO Base0 0xffff
	tpm_nsc 0000:00:1f.0: NSC IO Base1 0xffff
	tpm_nsc 0000:00:1f.0: NSC Interrupt number and wakeup 0xff
	tpm_nsc 0000:00:1f.0: NSC IRQ type select 0xff
	tpm_nsc 0000:00:1f.0: NSC DMA channel select0 0xff, select1 0xff
	tpm_nsc 0000:00:1f.0: NSC Config 0xff 0xff 0xff 0xff 0xff 0xff 0xff 0xff 0xff 0xff
	tpm_nsc 0000:00:1f.0: NSC PC21100 TPM revision 31

Trying to read from /sys/class/misc/tpm0/device/pcrs results in:
	tpm_nsc 0000:00:1f.0: IBF timeout
	tpm_nsc 0000:00:1f.0: tpm_transmit: tpm_send: error 4294967291

I am guessing that this is indeed not a NSC chip. 

I also tried using the Atmel driver by adding the same PCI IDs. But
again the reading of registers 4..7 indicated it is not.

Do you have an idea on how to get the device working?

Best Regards
Jens

PS: I am not subscribed to LKML, so please send copies of replies to me.

Re: TPM on Thinkpad T43

[Jens Taprogge]

On Fri, Jun 10, 2005 at 02:44:06PM -0500, Kylene Jo Hall wrote:
> Jens, Gang,
> 
> Thanks, for your very helpful reports.  I have received access to a
> machine with this type and am currently working to get it working.  Jens
> you do have an NSC part but its seems that more has changed.  If you
> want to try further testing for me you can set TPM_NSC_BASE to 0x378 or
> use the version in the -mm patch that reads this value automatically
> instead of setting the value.  Also try removing all calls to
> tpm_write_index in the tpm_nsc_init function.  Either way I'll get back
> to you when we have something working.


Hello Kylie,

2.6.12-rc6-mm1 with the additional PCI IDs gives the following
debugging output (I have added some and made the driver ignore the wrong
SID INDEX):
	tpm_nsc 0000:00:1f.0: NSC TPM base=0xffff
	tpm_nsc 0000:00:1f.0: NSC TPM SID INDEX 0xff
	tpm_nsc 0000:00:1f.0: NSC TPM detected
	tpm_nsc 0000:00:1f.0: NSC LDN 0xff, SID 0xff, SRID 0xff
	tpm_nsc 0000:00:1f.0: NSC SIOCF1 0xff SIOCF5 0xff SIOCF6 0xff SIOCF8 0xff
	tpm_nsc 0000:00:1f.0: NSC IO Base0 0xffff
	tpm_nsc 0000:00:1f.0: NSC IO Base1 0xffff
	tpm_nsc 0000:00:1f.0: NSC Interrupt number and wakeup 0xff
	tpm_nsc 0000:00:1f.0: NSC IRQ type select 0xff
	tpm_nsc 0000:00:1f.0: NSC DMA channel select0 0xff, select1 0xff
	tpm_nsc 0000:00:1f.0: NSC Config 0xff 0xff 0xff 0xff 0xff 0xff 0xff 0xff 0xff 0xff
	tpm_nsc 0000:00:1f.0: NSC PC21100 TPM revision 31

If can be of further assistance tracking down the problem, please let me
know.

Best Regards
Jens

Re: TPM on Thinkpad T43

[Kylene Jo Hall]

Try redefinig TPM_DATA and TPM_ADDR to 0x2F and 0x2E in tpm.h

Thanks,
Kylie

On Sat, 2005-06-11 at 11:29 +0200, Jens Taprogge wrote:
> On Fri, Jun 10, 2005 at 02:44:06PM -0500, Kylene Jo Hall wrote:
> > Jens, Gang,
> > 
> > Thanks, for your very helpful reports.  I have received access to a
> > machine with this type and am currently working to get it working.  Jens
> > you do have an NSC part but its seems that more has changed.  If you
> > want to try further testing for me you can set TPM_NSC_BASE to 0x378 or
> > use the version in the -mm patch that reads this value automatically
> > instead of setting the value.  Also try removing all calls to
> > tpm_write_index in the tpm_nsc_init function.  Either way I'll get back
> > to you when we have something working.
> 
> 
> Hello Kylie,
> 
> 2.6.12-rc6-mm1 with the additional PCI IDs gives the following
> debugging output (I have added some and made the driver ignore the wrong
> SID INDEX):
> 	tpm_nsc 0000:00:1f.0: NSC TPM base=0xffff
> 	tpm_nsc 0000:00:1f.0: NSC TPM SID INDEX 0xff
> 	tpm_nsc 0000:00:1f.0: NSC TPM detected
> 	tpm_nsc 0000:00:1f.0: NSC LDN 0xff, SID 0xff, SRID 0xff
> 	tpm_nsc 0000:00:1f.0: NSC SIOCF1 0xff SIOCF5 0xff SIOCF6 0xff SIOCF8 0xff
> 	tpm_nsc 0000:00:1f.0: NSC IO Base0 0xffff
> 	tpm_nsc 0000:00:1f.0: NSC IO Base1 0xffff
> 	tpm_nsc 0000:00:1f.0: NSC Interrupt number and wakeup 0xff
> 	tpm_nsc 0000:00:1f.0: NSC IRQ type select 0xff
> 	tpm_nsc 0000:00:1f.0: NSC DMA channel select0 0xff, select1 0xff
> 	tpm_nsc 0000:00:1f.0: NSC Config 0xff 0xff 0xff 0xff 0xff 0xff 0xff 0xff 0xff 0xff
> 	tpm_nsc 0000:00:1f.0: NSC PC21100 TPM revision 31
> 
> If can be of further assistance tracking down the problem, please let me
> know.
> 
> Best Regards
> Jens
>