* PATCH: IDE timing violation on reset
@ 2005-06-20 20:13 Alan Cox
0 siblings, 0 replies; only message in thread
From: Alan Cox @ 2005-06-20 20:13 UTC (permalink / raw)
To: Linux Kernel Mailing List, akpm
Pretty much theoretical for non MMIO thankfully. We _must_ use OUTBSYNC
for commands or they may be posted and thus ruin the 400nS required
delay.
Signed-off-by: Alan Cox <alan@redhat.com>
diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.12/drivers/ide/ide-iops.c linux-2.6.12/drivers/ide/ide-iops.c
--- linux.vanilla-2.6.12/drivers/ide/ide-iops.c 2005-06-19 11:30:47.000000000 +0100
+++ linux-2.6.12/drivers/ide/ide-iops.c 2005-06-20 20:44:22.000000000 +0100
@@ -1181,7 +1181,8 @@
pre_reset(drive);
SELECT_DRIVE(drive);
udelay (20);
- hwif->OUTB(WIN_SRST, IDE_COMMAND_REG);
+ hwif->OUTBSYNC(drive, WIN_SRST, IDE_COMMAND_REG);
+ ndelay(400);
hwgroup->poll_timeout = jiffies + WAIT_WORSTCASE;
hwgroup->polling = 1;
__ide_set_handler(drive, &atapi_reset_pollfunc, HZ/20, NULL);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2005-06-20 21:00 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-06-20 20:13 PATCH: IDE timing violation on reset Alan Cox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®