* [PATCH] ufs: host: Remove redundant dev_err()
@ 2026-07-17 3:50 Pan Chuang
2026-07-17 6:35 ` Peter Wang (王信友)
0 siblings, 1 reply; 2+ messages in thread
From: Pan Chuang @ 2026-07-17 3:50 UTC (permalink / raw)
To: Peter Wang, Chaotian Jing, Stanley Jhu, James E.J. Bottomley,
Martin K. Petersen, Manivannan Sadhasivam, Matthias Brugger,
AngeloGioacchino Del Regno,
open list:UNIVERSAL FLASH STORAGE HOST CONTROLLER DRIVER...,
moderated list:UNIVERSAL FLASH STORAGE HOST CONTROLLER DRIVER...,
open list,
open list:UNIVERSAL FLASH STORAGE HOST CONTROLLER DRIVER...,
moderated list:ARM/Mediatek SoC support:Keyword:mediatek
Cc: Pan Chuang
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/ufs/host/ufs-mediatek.c | 4 +---
drivers/ufs/host/ufs-qcom.c | 2 --
2 files changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/ufs/host/ufs-mediatek.c b/drivers/ufs/host/ufs-mediatek.c
index 3991a51263a6..98ea9aa2a39c 100644
--- a/drivers/ufs/host/ufs-mediatek.c
+++ b/drivers/ufs/host/ufs-mediatek.c
@@ -2266,10 +2266,8 @@ static int ufs_mtk_config_mcq_irq(struct ufs_hba *hba)
dev_dbg(hba->dev, "request irq %d intr %s\n", irq, ret ? "failed" : "");
- if (ret) {
- dev_err(hba->dev, "Cannot request irq %d\n", ret);
+ if (ret)
return ret;
- }
}
host->is_mcq_intr_enabled = true;
diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
index 291c43448764..7d690ea2fa67 100644
--- a/drivers/ufs/host/ufs-qcom.c
+++ b/drivers/ufs/host/ufs-qcom.c
@@ -2431,8 +2431,6 @@ static int ufs_qcom_config_esi(struct ufs_hba *hba)
ret = devm_request_irq(hba->dev, qi[idx].irq, ufs_qcom_mcq_esi_handler,
IRQF_SHARED, "qcom-mcq-esi", qi + idx);
if (ret) {
- dev_err(hba->dev, "%s: Failed to request IRQ for %d, err = %d\n",
- __func__, qi[idx].irq, ret);
/* Free previously allocated IRQs */
for (int j = 0; j < idx; j++)
devm_free_irq(hba->dev, qi[j].irq, qi + j);
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ufs: host: Remove redundant dev_err()
2026-07-17 3:50 [PATCH] ufs: host: Remove redundant dev_err() Pan Chuang
@ 2026-07-17 6:35 ` Peter Wang (王信友)
0 siblings, 0 replies; 2+ messages in thread
From: Peter Wang (王信友) @ 2026-07-17 6:35 UTC (permalink / raw)
To: linux-arm-kernel, chu.stanley, AngeloGioacchino Del Regno,
linux-scsi, Chaotian Jing (井朝天),
panchuang, linux-arm-msm, linux-kernel, matthias.bgg,
James.Bottomley, mani, linux-mediatek, martin.petersen
On Fri, 2026-07-17 at 11:50 +0800, Pan Chuang wrote:
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() calls.
>
> Signed-off-by: Pan Chuang <panchuang@vivo.com>
> ---
Reviewed-by: Peter Wang <peter.wang@mediatek.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-07-17 6:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-07-17 3:50 [PATCH] ufs: host: Remove redundant dev_err() Pan Chuang
2026-07-17 6:35 ` Peter Wang (王信友)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox