From: Daniel McNeil <daniel@osdl.org>
To: "linux-aio@kvack.org" <linux-aio@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [rfc patch 2/2] direct-io: remove address alignment check
Date: Wed, 13 Jul 2005 16:43:21 -0700 [thread overview]
Message-ID: <1121298112.6025.21.camel@ibm-c.pdx.osdl.net> (raw)
This patch relaxes the direct i/o alignment check so that user addresses
do not have to be a multiple of the device block size.
I've done some preliminary testing and it mostly works on an ext3
file system on a ide disk. I have seen trouble when the user address
is on an odd byte boundary. Sometimes the data is read back incorrectly
on read and sometimes I get these kernel error messages:
hda: dma_timer_expiry: dma status == 0x60
hda: DMA timeout retry
hda: timeout waiting for DMA
hda: status error: status=0x58 { DriveReady SeekComplete DataRequest }
ide: failed opcode was: unknown
hda: drive not ready for command
Doing direct-io with user addresses on even, non-512 boundaries appears
to be working correctly.
Any additional testing and/or comments welcome.
Signed-off-by: Daniel McNeil <daniel@osdl.org>
--- linux-2.6.12.orig/fs/direct-io.c 2005-06-28 16:39:39.000000000 -0700
+++ linux-2.6.12/fs/direct-io.c 2005-06-28 16:39:59.000000000 -0700
@@ -1147,7 +1147,9 @@ __blockdev_direct_IO(int rw, struct kioc
goto out;
}
- /* Check the memory alignment. Blocks cannot straddle pages */
+ /*
+ * Check the i/o. It must be a multiple of device block size.
+ */
for (seg = 0; seg < nr_segs; seg++) {
addr = (unsigned long)iov[seg].iov_base;
size = iov[seg].iov_len;
@@ -1156,7 +1158,7 @@ __blockdev_direct_IO(int rw, struct kioc
if (bdev)
blkbits = bdev_blkbits;
blocksize_mask = (1 << blkbits) - 1;
- if ((addr & blocksize_mask) || (size & blocksize_mask))
+ if (size & blocksize_mask)
goto out;
}
}
next reply other threads:[~2005-07-13 23:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-13 23:43 Daniel McNeil [this message]
2005-07-14 23:16 ` Badari Pulavarty
2005-07-14 23:44 ` Daniel McNeil
2005-07-15 5:27 ` Badari Pulavarty
2005-07-15 20:06 ` Daniel McNeil
2005-07-15 0:28 ` Tejun Heo
2005-07-15 5:18 ` Badari Pulavarty
2005-07-15 8:23 ` Tejun Heo
2005-07-15 17:54 ` Badari Pulavarty
2005-07-16 3:50 ` Tejun Heo
2005-07-15 16:56 ` Joel Becker
2005-07-15 17:50 ` Badari Pulavarty
2005-07-15 19:16 ` Joel Becker
[not found] <1121298112.6025.21.camel@ibm-c.pdx.osdl.net.suse.lists.linux.kernel>
2005-07-14 13:18 ` Andi Kleen
2005-07-14 16:02 ` Daniel McNeil
2005-07-14 18:23 ` Andi Kleen
2005-07-14 20:40 ` Daniel McNeil
2005-07-14 23:39 ` Andrew Morton
2005-07-15 0:03 ` Daniel McNeil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1121298112.6025.21.camel@ibm-c.pdx.osdl.net \
--to=daniel@osdl.org \
--cc=linux-aio@kvack.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®