From: Daniel McNeil <daniel@osdl.org>
To: Andi Kleen <ak@suse.de>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [rfc patch 2/2] direct-io: remove address alignment check
Date: Thu, 14 Jul 2005 09:02:32 -0700 [thread overview]
Message-ID: <1121356952.6025.33.camel@ibm-c.pdx.osdl.net> (raw)
In-Reply-To: <p73hdex5xws.fsf@bragg.suse.de>
On Thu, 2005-07-14 at 06:18, Andi Kleen wrote:
> Daniel McNeil <daniel@osdl.org> writes:
>
> > This patch relaxes the direct i/o alignment check so that user addresses
> > do not have to be a multiple of the device block size.
>
> The original reason for this limit was that lots of drivers
> (not only IDE) explode when you give them odd sizes. Sometimes
> it is even worse.
>
> I doubt all of them have been fixed.
>
> Very risky change.
>
That is exactly why I made this a separate patch, so that we
can test and find out where the problems are and work to fix
them.
Are there problems only with odd sizes, or do drivers have problems
with non-512 sizes?
Allowing 4-byte aligned user addresses would be a good step
forward, since it looks like malloc() returns 4-byte aligned
addresses.
Daniel
next prev parent reply other threads:[~2005-07-14 16:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1121298112.6025.21.camel@ibm-c.pdx.osdl.net.suse.lists.linux.kernel>
2005-07-14 13:18 ` Andi Kleen
2005-07-14 16:02 ` Daniel McNeil [this message]
2005-07-14 18:23 ` Andi Kleen
2005-07-14 20:40 ` Daniel McNeil
2005-07-14 23:39 ` Andrew Morton
2005-07-15 0:03 ` Daniel McNeil
2005-07-13 23:43 Daniel McNeil
2005-07-14 23:16 ` Badari Pulavarty
2005-07-14 23:44 ` Daniel McNeil
2005-07-15 5:27 ` Badari Pulavarty
2005-07-15 20:06 ` Daniel McNeil
2005-07-15 0:28 ` Tejun Heo
2005-07-15 5:18 ` Badari Pulavarty
2005-07-15 8:23 ` Tejun Heo
2005-07-15 17:54 ` Badari Pulavarty
2005-07-16 3:50 ` Tejun Heo
2005-07-15 16:56 ` Joel Becker
2005-07-15 17:50 ` Badari Pulavarty
2005-07-15 19:16 ` Joel Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1121356952.6025.33.camel@ibm-c.pdx.osdl.net \
--to=daniel@osdl.org \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®