* [PATCH] nfsd to unlock kernel before exiting
@ 2005-08-17 18:25 Steven Rostedt
0 siblings, 0 replies; only message in thread
From: Steven Rostedt @ 2005-08-17 18:25 UTC (permalink / raw)
To: LKML; +Cc: K.R. Foley, Ingo Molnar, Linus Torvalds, Andrew Morton
The nfsd holds the big kernel lock upon exit, when it really shouldn't.
Not to mention that this breaks Ingo's RT patch. This is a trivial fix
to release the lock.
Ingo, this patch also works with your kernel, and stops the problem with
nfsd.
Note, there's a "goto out;" where "out:" is right above svc_exit_thread.
The point of the goto also holds the kernel_lock, so I don't see any
problem here in releasing it.
-- Steve
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
--- linux-2.6.13-rc6-git4/fs/nfsd/nfssvc.c.orig 2005-08-17 14:12:02.000000000 -0400
+++ linux-2.6.13-rc6-git4/fs/nfsd/nfssvc.c 2005-08-17 14:12:25.000000000 -0400
@@ -287,6 +287,7 @@ out:
svc_exit_thread(rqstp);
/* Release module */
+ unlock_kernel();
module_put_and_exit(0);
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2005-08-17 18:25 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-08-17 18:25 [PATCH] nfsd to unlock kernel before exiting Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome