* [PATCH] aacraid: 2.6.13 aacraid bad BUG_ON fix
@ 2005-09-01 15:19 Mark Haverkamp
0 siblings, 0 replies; only message in thread
From: Mark Haverkamp @ 2005-09-01 15:19 UTC (permalink / raw)
To: James Bottomley, Andrew Morton; +Cc: linux-scsi, linux-kernel, Mark Salyzyn
This was noticed by Doug Bazamic and the fix found by Mark Salyzyn at
Adaptec.
There was an error in the BUG_ON() statement that validated the
calculated fib size which can cause the driver to panic.
Signed-off-by: Mark Haverkamp <markh@osdl.org>
--- a/drivers/scsi/aacraid/aachba.c 2005-08-28 19:41:01.000000000 -0400
+++ b/drivers/scsi/aacraid/aachba.c 2005-09-01 08:05:29.118304656 -0400
@@ -968,7 +968,7 @@
fibsize = sizeof(struct aac_read64) +
((le32_to_cpu(readcmd->sg.count) - 1) *
sizeof (struct sgentry64));
- BUG_ON (fibsize > (sizeof(struct hw_fib) -
+ BUG_ON (fibsize > (dev->max_fib_size -
sizeof(struct aac_fibhdr)));
/*
* Now send the Fib to the adapter
--
Mark Haverkamp <markh@osdl.org>
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2005-09-01 15:22 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-09-01 15:19 [PATCH] aacraid: 2.6.13 aacraid bad BUG_ON fix Mark Haverkamp
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®