* [PATCH] module-init-tools: don't do '-' substitutions in depmod
@ 2005-09-08 19:56 Bill Nottingham
2005-09-09 1:11 ` Rusty Russell
0 siblings, 1 reply; 2+ messages in thread
From: Bill Nottingham @ 2005-09-08 19:56 UTC (permalink / raw)
To: linux-kernel; +Cc: rusty, adam
[-- Attachment #1: Type: text/plain, Size: 177 bytes --]
The attached patch removes the '-' for '_' substitution from
depmod - this makes the names printed for modules in module.alias
match the actual names of the module files.
Bill
[-- Attachment #2: module-init-tools.patch --]
[-- Type: text/plain, Size: 463 bytes --]
diff -ru depmod.c.old depmod.c
--- depmod.c 2005-04-30 08:38:46.000000000 -0400
+++ depmod.c 2005-09-08 15:52:26.000000000 -0400
@@ -607,13 +607,8 @@
else
afterslash++;
- /* Convert to underscores, stop at first . */
- for (i = 0; afterslash[i] && afterslash[i] != '.'; i++) {
- if (afterslash[i] == '-')
- modname[i] = '_';
- else
+ for (i = 0; afterslash[i] && afterslash[i] != '.'; i++)
modname[i] = afterslash[i];
- }
modname[i] = '\0';
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] module-init-tools: don't do '-' substitutions in depmod
2005-09-08 19:56 [PATCH] module-init-tools: don't do '-' substitutions in depmod Bill Nottingham
@ 2005-09-09 1:11 ` Rusty Russell
0 siblings, 0 replies; 2+ messages in thread
From: Rusty Russell @ 2005-09-09 1:11 UTC (permalink / raw)
To: Bill Nottingham; +Cc: linux-kernel, adam
On Thu, 2005-09-08 at 15:56 -0400, Bill Nottingham wrote:
> The attached patch removes the '-' for '_' substitution from
> depmod - this makes the names printed for modules in module.alias
> match the actual names of the module files.
Looks fine, thanks Bill!
(Note: this is harmless, because modprobe canonicalizes them itself when
reading the file anyway, so no change there).
Rusty.
--
A bad analogy is like a leaky screwdriver -- Richard Braakman
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-09-09 1:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-09-08 19:56 [PATCH] module-init-tools: don't do '-' substitutions in depmod Bill Nottingham
2005-09-09 1:11 ` Rusty Russell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®