From: john stultz <johnstul@us.ibm.com>
To: Andrew Morton <akpm@osdl.org>
Cc: lkml <linux-kernel@vger.kernel.org>, Andi Kleen <ak@suse.de>
Subject: [PATCH] x86-64: Fix bad assumption that dualcore cpus have synced TSCs
Date: Mon, 19 Sep 2005 12:16:43 -0700 [thread overview]
Message-ID: <1127157404.3455.209.camel@cog.beaverton.ibm.com> (raw)
Andrew,
This patch should resolve the issue seen in bugme bug #5105, where it
is assumed that dualcore x86_64 systems have synced TSCs. This is not
the case, and alternate timesources should be used instead.
For more details, see:
http://bugzilla.kernel.org/show_bug.cgi?id=5105
Please consider for inclusion in your tree.
thanks
-john
diff --git a/arch/x86_64/kernel/time.c b/arch/x86_64/kernel/time.c
--- a/arch/x86_64/kernel/time.c
+++ b/arch/x86_64/kernel/time.c
@@ -959,9 +959,6 @@ static __init int unsynchronized_tsc(voi
are handled in the OEM check above. */
if (boot_cpu_data.x86_vendor == X86_VENDOR_INTEL)
return 0;
- /* All in a single socket - should be synchronized */
- if (cpus_weight(cpu_core_map[0]) == num_online_cpus())
- return 0;
#endif
/* Assume multi socket systems are not synchronized */
return num_online_cpus() > 1;
next reply other threads:[~2005-09-19 19:17 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-19 19:16 john stultz [this message]
2005-09-19 19:31 ` Andi Kleen
2005-09-19 19:42 ` john stultz
2005-09-19 19:49 ` [discuss] " Andi Kleen
2005-09-20 18:59 ` john stultz
2005-09-21 4:03 ` Daniel Jacobowitz
2005-09-21 15:15 ` Ray Bryant
2005-09-21 15:04 ` Andi Kleen
2005-09-21 15:46 ` Ray Bryant
2005-09-22 8:00 ` Jonas Oreland
2005-09-21 20:17 ` Andrew Morton
2005-10-07 12:26 ` Vladimir B. Savkin
2005-10-07 12:31 ` Andi Kleen
2005-10-07 14:15 ` Vladimir B. Savkin
2005-10-07 14:21 ` [discuss] " Velu Erwan
2005-10-08 10:11 ` Vladimir B. Savkin
2005-10-10 18:03 ` john stultz
2005-10-10 18:12 ` Vladimir B. Savkin
2005-10-10 18:19 ` Jonas Oreland
2005-10-11 7:35 ` Vladimir B. Savkin
2005-10-11 8:06 ` Andi Kleen
2005-10-11 16:27 ` Jonas Oreland
2005-10-25 7:35 ` x86-64: Syncing dualcore cpus TSCs Jonas Oreland
2005-10-25 7:42 ` Andi Kleen
2005-10-26 0:05 ` David Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1127157404.3455.209.camel@cog.beaverton.ibm.com \
--to=johnstul@us.ibm.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®