From: john stultz <johnstul@us.ibm.com>
To: tglx@linutronix.de
Cc: Christoph Lameter <clameter@engr.sgi.com>,
linux-kernel@vger.kernel.org, mingo@elte.hu, akpm@osdl.org,
george@mvista.com, paulmck@us.ibm.com
Subject: Re: [ANNOUNCE] ktimers subsystem
Date: Mon, 19 Sep 2005 15:50:52 -0700 [thread overview]
Message-ID: <1127170253.3455.236.camel@cog.beaverton.ibm.com> (raw)
In-Reply-To: <1127169849.24044.279.camel@tglx.tec.linutronix.de>
On Tue, 2005-09-20 at 00:44 +0200, Thomas Gleixner wrote:
> On Mon, 2005-09-19 at 15:24 -0700, Christoph Lameter wrote:
>
> > > We should rather ask glibc people why gettimeofday() / clock_getttime()
> > > is called inside the library code all over the place for non obvious
> > > reasons.
> >
> > You can ask lots of application vendors the same question because its all
> > over lots of user space code. The fact is that gettimeofday() /
> > clock_gettime() efficiency is very critical to the performance of many
> > applications on Linux. That is why the addtion of one add instruction may
> > better be carefully considered.
>
> Hmm. I don't understand the argument line completely.
>
> 1. The kernel has to provide ugly mechanisms because a lot of
> applications implementations are doing the Wrong Thing ?
>
> 2. All gettimeofday implementations I have looked at do a lot of math
> anyway, so its definitely more interesting to look at those oddities
> rather than discussing a single add. John Stulz timeofday rework have a
> clean solution for this - please do not argue about the div64 in his
> original patches which he is reworking at the moment.
The simplest solution is to keep wall-time maintained in a timespec as
well as the nsec_t based system_time/wall_time_offset combo. This avoids
the extra add in the hotpath, and only costs an extra add at interrupt
time.
I'll have an updated patch that includes some of Roman's suggestions
from earlier soon.
> > Many platforms can execute gettimeofday
> > without having to enter the kernel.
>
> Which ones ? How is this achieved with respect to all the time adjust,
> correction... code ?
Many arches have userspace gtod implementations (x86-64, ppc64, and ia64
as well). Although my timeofday code allows for this as well (I had it
working for x86-64 awhile back).
thanks
-john
next prev parent reply other threads:[~2005-09-19 22:50 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-19 16:48 tglx
2005-09-19 16:48 ` [PATCH] " tglx
2005-09-19 21:47 ` [ANNOUNCE] " Thomas Gleixner
2005-09-19 22:03 ` Christoph Lameter
2005-09-19 22:17 ` Thomas Gleixner
2005-09-19 22:24 ` Christoph Lameter
2005-09-19 22:44 ` Thomas Gleixner
2005-09-19 22:50 ` john stultz [this message]
2005-09-19 22:58 ` Thomas Gleixner
2005-09-19 23:04 ` Christoph Lameter
2005-09-19 23:12 ` Thomas Gleixner
2005-09-20 7:14 ` Ingo Molnar
2005-09-20 7:10 ` Ingo Molnar
2005-09-21 19:24 ` Pavel Machek
2005-09-19 22:39 ` Christopher Friesen
2005-09-19 22:54 ` Thomas Gleixner
2005-09-20 4:57 ` Christopher Friesen
2005-09-20 5:11 ` Thomas Gleixner
2005-09-20 0:43 ` George Anzinger
2005-09-21 19:50 ` Roman Zippel
2005-09-21 22:41 ` Thomas Gleixner
2005-09-22 12:59 ` Ingo Molnar
2005-09-22 23:09 ` Roman Zippel
2005-09-22 23:31 ` Christopher Friesen
2005-09-23 0:25 ` Roman Zippel
2005-09-23 6:49 ` Thomas Gleixner
2005-09-24 3:15 ` Roman Zippel
2005-09-24 5:16 ` Ingo Molnar
2005-09-24 10:35 ` Roman Zippel
2005-09-24 13:56 ` Thomas Gleixner
2005-09-24 16:51 ` Daniel Walker
2005-09-24 23:45 ` Roman Zippel
2005-09-25 21:00 ` Thomas Gleixner
2005-09-27 16:54 ` Roman Zippel
2005-09-27 19:03 ` Tim Bird
2005-09-28 16:36 ` Roman Zippel
2005-09-25 21:02 ` Thomas Gleixner
2005-09-27 16:48 ` Roman Zippel
2005-09-27 18:38 ` Tim Bird
2005-09-27 20:36 ` George Anzinger
2005-09-23 2:25 ` john stultz
2005-09-23 8:27 ` Thomas Gleixner
2005-09-24 2:43 ` Roman Zippel
2005-09-24 5:03 ` Ingo Molnar
2005-09-24 9:04 ` James Bruce
2005-09-23 15:21 ` Paul E. McKenney
2005-09-24 3:38 ` Roman Zippel
2005-09-25 15:48 Sid Boyce
2005-09-25 18:20 ` Zwane Mwaikambo
2005-09-26 0:02 ` Sid Boyce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1127170253.3455.236.camel@cog.beaverton.ibm.com \
--to=johnstul@us.ibm.com \
--cc=akpm@osdl.org \
--cc=clameter@engr.sgi.com \
--cc=george@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulmck@us.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®