mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Shawn Guo <shawn.guo@freescale.com>,
	ashishj3 <ashish.jangam@kpitcummins.com>,
	Dajun <dajun.chen@diasemi.com>,
	sameo@openedhand.com, linaro-dev@lists.linaro.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/11] MFD: DA9052 MFD core module v2
Date: Thu, 21 Jul 2011 22:40:23 +0200	[thread overview]
Message-ID: <11313494.PB6mQOoBLX@wuerfel> (raw)
In-Reply-To: <20110721154748.GB23192@opensource.wolfsonmicro.com>

On Thursday 21 July 2011 16:47:48 Mark Brown wrote:
> On Thu, Jul 21, 2011 at 11:46:32PM +0800, Shawn Guo wrote:
> > On Tue, Jul 05, 2011 at 08:07:00PM +0530, ashishj3 wrote:
> 
> > > +   mutex_lock_interruptible(&da9052->io_lock);
> 
> > Compile warning as below.
> 
> > "warning: ignoring return value of ‘mutex_lock_interruptible’,
> > declared with attribute warn_unused_result"
> 
> Although the bigger problem is why are these interruptible?  That's
> very unusual.

Well, the default should really be to use _interruptible or at least
_killable with the appropriate error handling, and only use noninterruptible
locks  in cases where that's not possible.

In the funtions that Shawn pointed out, there is an error return, so it would
be possible to do that, but the callers would need to be audited carefully.

	Arnd

  reply	other threads:[~2011-07-21 20:40 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-05 14:37 ashishj3
2011-07-05 14:55 ` Arnd Bergmann
2011-07-11  6:57   ` Ashish Jangam
2011-07-11  7:03     ` Mark Brown
2011-07-12 18:32     ` Arnd Bergmann
2011-07-12 18:40       ` Ashish Jangam
2011-07-21 15:46 ` Shawn Guo
2011-07-21 15:47   ` Mark Brown
2011-07-21 20:40     ` Arnd Bergmann [this message]
2011-07-22  8:59       ` Mark Brown
2011-07-23  9:50         ` Arnd Bergmann
2011-07-23 10:43           ` Mark Brown
2011-07-21 16:07 ` Shawn Guo
2011-07-24 18:49 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11313494.PB6mQOoBLX@wuerfel \
    --to=arnd@arndb.de \
    --cc=ashish.jangam@kpitcummins.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=dajun.chen@diasemi.com \
    --cc=linaro-dev@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sameo@openedhand.com \
    --cc=shawn.guo@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®