From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: ashishj3 <ashish.jangam@kpitcummins.com>
Cc: arnd@arndb.de, sameo@openedhand.com,
linux-kernel@vger.kernel.org, Dajun <dajun.chen@diasemi.com>,
linaro-dev@lists.linaro.org
Subject: Re: [PATCH 01/11] MFD: DA9052 MFD core module v2
Date: Sun, 24 Jul 2011 19:49:34 +0100 [thread overview]
Message-ID: <20110724184934.GA29931@sirena.org.uk> (raw)
In-Reply-To: <1309876620.960.169.camel@L-0532.kpit.com>
On Tue, Jul 05, 2011 at 08:07:00PM +0530, ashishj3 wrote:
> +int da9052_set_bits(struct da9052 *da9052, unsigned char reg,
> + unsigned char bit_mask)
> +{
> + unsigned char val;
> + int ret;
> +
> + if (reg > DA9052_MAX_REG_CNT) {
> + dev_err(da9052->dev, "invalid reg %x\n", reg);
> + return -EINVAL;
> + }
> +
> + mutex_lock_interruptible(&da9052->io_lock);
Linus has now merged the regmap code (include/linux/regmap.h and
drivers/base/regmap) which means that your register I/O code should
probably be redone in terms of that - it shoud factor a lot of code out
of the driver.
prev parent reply other threads:[~2011-07-24 18:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-05 14:37 ashishj3
2011-07-05 14:55 ` Arnd Bergmann
2011-07-11 6:57 ` Ashish Jangam
2011-07-11 7:03 ` Mark Brown
2011-07-12 18:32 ` Arnd Bergmann
2011-07-12 18:40 ` Ashish Jangam
2011-07-21 15:46 ` Shawn Guo
2011-07-21 15:47 ` Mark Brown
2011-07-21 20:40 ` Arnd Bergmann
2011-07-22 8:59 ` Mark Brown
2011-07-23 9:50 ` Arnd Bergmann
2011-07-23 10:43 ` Mark Brown
2011-07-21 16:07 ` Shawn Guo
2011-07-24 18:49 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110724184934.GA29931@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=arnd@arndb.de \
--cc=ashish.jangam@kpitcummins.com \
--cc=dajun.chen@diasemi.com \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@openedhand.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®