mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: john stultz <johnstul@us.ibm.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: dino@in.ibm.com, linux-kernel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: IO-APIC problem with 2.6.14-rt9
Date: Thu, 10 Nov 2005 13:42:54 -0800	[thread overview]
Message-ID: <1131658975.27168.703.camel@cog.beaverton.ibm.com> (raw)
In-Reply-To: <20051110210458.GA6097@elte.hu>

On Thu, 2005-11-10 at 22:04 +0100, Ingo Molnar wrote:
> * john stultz <johnstul@us.ibm.com> wrote:
> 
> > > > //#define ARCH_HAS_READ_CURRENT_TIMER  1
> > > > 
> > > > to:
> > > > 
> > > > #define ARCH_HAS_READ_CURRENT_TIMER  1
> > > > 
> > > > ?
> > > 
> > > It works !!  Thanks Ingo for the immediate response
> > 
> > Hrm. Could you post the value for BogoMIPS that you're getting now?
> > 
> > My patches touch the __delay() code, since using the TSC based delay 
> > has just as many, if not more, problems as the loop based delay. So I 
> > want to be careful that my changes are not further causing problems.
> > 
> > Ingo, did you commented out ARCH_HAS_READ_CURRENT_TIMER because of 
> > problems with the new calibration code?
> 
> yes. traces show that the new calibration code results in a bogomips 
> value on Athlon64 CPUs that halve the timeout. I.e. udelay(100) now 
> takes 50 usecs (!). The calibration code seems to assume the number of 
> cycles == number of loops in __delay() - that is not valid.

Yea, that makes sense, because the READ_CURRENT_TIMER calibration is all
TSC based and with my code we use the loop based delay (since the TSC
based one can have a number of problems). So that doesn't mesh well when
the loop/cycle values are not equivalent.

That still leaves open the question why Dinakar is seeing issues w/ the
loop based calibration, but I've got some similar hardware in my lab, so
I can probably work that out.

I'll see if I can't avoid touching the delay code. Its such a sketchy
calibration sensitive code path that I'd really like to see it killed,
but maybe there's something simple that can be done.

Grumble. :( I was hoping to submit my tod code to Andrew tomorrow, but
this might block that. 

thanks
-john





  reply	other threads:[~2005-11-10 21:42 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-10 20:02 Dinakar Guniguntala
2005-11-10 20:02 ` Ingo Molnar
2005-11-10 20:30   ` Dinakar Guniguntala
2005-11-10 20:29     ` john stultz
2005-11-10 20:55       ` Dinakar Guniguntala
2005-11-10 21:04       ` Ingo Molnar
2005-11-10 21:42         ` john stultz [this message]
2005-11-11  7:38           ` Ingo Molnar
2005-11-11  8:20             ` Ingo Molnar
2005-11-12  2:25 Pallipadi, Venkatesh
2005-11-12  2:34 ` john stultz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1131658975.27168.703.camel@cog.beaverton.ibm.com \
    --to=johnstul@us.ibm.com \
    --cc=dino@in.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®