mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [BUG][PATCH] process events connector - uid_t gid_t size issues
@ 2005-11-28 23:35 Matt Helsley
  0 siblings, 0 replies; only message in thread
From: Matt Helsley @ 2005-11-28 23:35 UTC (permalink / raw)
  To: Andrew Morton
  Cc: LKML, Evgeniy Polyakov, Jean-Pierre Dion, Guillaume Thouvenin,
	Badari Pulavarty, Ram Pai, CKRM-Tech, Erich Focht, elsa-devel,
	Gerrit Huizenga, Adrian Bunk, Chandra S. Seetharaman, Jay Lan,
	Erik Jacobson, Jack Steiner, larva

Andrew,

	I noticed this follow up patch did not make it's way into -mm and
subsequently to 2.6.15-rc2. The uid_t and gid_t fields appear to present
a 32/64-bit userspace/kernel problem for some archs.

	This patch addresses the problem by fixing the size to the largest
size for uid_t/gid_t used in the kernel. This preserves the total size of
the event structure while ensuring that the layouts of the ID change event
match in 32 and 64-bit kernels and applications.

	Please apply.

Signed-off-by: Matt Helsley <matthltc@us.ibm.com>

---

Index: linux-2.6.15-rc2/include/linux/cn_proc.h
===================================================================
--- linux-2.6.15-rc2.orig/include/linux/cn_proc.h
+++ linux-2.6.15-rc2/include/linux/cn_proc.h
@@ -84,16 +84,16 @@ struct proc_event {
 
 		struct id_proc_event {
 			pid_t process_pid;
 			pid_t process_tgid;
 			union {
-				uid_t ruid; /* current->uid */
-				gid_t rgid; /* current->gid */
+				__u32 ruid; /* task uid */
+				__u32 rgid; /* task gid */
 			} r;
 			union {
-				uid_t euid;
-				gid_t egid;
+				__u32 euid;
+				__u32 egid;
 			} e;
 		} id;
 
 		struct exit_proc_event {
 			pid_t process_pid;



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2005-11-28 23:41 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-11-28 23:35 [BUG][PATCH] process events connector - uid_t gid_t size issues Matt Helsley

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®