* [PATCH] remove uneccesary page++
@ 2006-01-11 1:28 Greg Ungerer
2006-01-11 2:15 ` Dave Hansen
0 siblings, 1 reply; 2+ messages in thread
From: Greg Ungerer @ 2006-01-11 1:28 UTC (permalink / raw)
To: linux-kernel
Remove unecessary page++ from memmap_init_zone loop.
Signed-off-by: Greg Ungerer <gerg@uclinux.org>
--- linux-2.6.15/mm/page_alloc.c 2006-01-03 13:21:10.000000000 +1000
+++ linux-2.6.15-uc0/mm/page_alloc.c 2006-01-11 11:16:46.981376296 +1000
@@ -1706,7 +1706,7 @@
unsigned long end_pfn = start_pfn + size;
unsigned long pfn;
- for (pfn = start_pfn; pfn < end_pfn; pfn++, page++) {
+ for (pfn = start_pfn; pfn < end_pfn; pfn++) {
if (!early_pfn_valid(pfn))
continue;
if (!early_pfn_in_nid(pfn, nid))
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] remove uneccesary page++
2006-01-11 1:28 [PATCH] remove uneccesary page++ Greg Ungerer
@ 2006-01-11 2:15 ` Dave Hansen
0 siblings, 0 replies; 2+ messages in thread
From: Dave Hansen @ 2006-01-11 2:15 UTC (permalink / raw)
To: Greg Ungerer; +Cc: linux-kernel, Andy Wihitcroft
On Wed, 2006-01-11 at 11:28 +1000, Greg Ungerer wrote:
> Remove unecessary page++ from memmap_init_zone loop.
>
> Signed-off-by: Greg Ungerer <gerg@uclinux.org>
>
>
> --- linux-2.6.15/mm/page_alloc.c 2006-01-03 13:21:10.000000000 +1000
> +++ linux-2.6.15-uc0/mm/page_alloc.c 2006-01-11 11:16:46.981376296 +1000
> @@ -1706,7 +1706,7 @@
> unsigned long end_pfn = start_pfn + size;
> unsigned long pfn;
>
> - for (pfn = start_pfn; pfn < end_pfn; pfn++, page++) {
> + for (pfn = start_pfn; pfn < end_pfn; pfn++) {
> if (!early_pfn_valid(pfn))
> continue;
> if (!early_pfn_in_nid(pfn, nid))
You're right. Somebody missed that when we made it re-calculate the
struct page each time. Probably from the sparsemem updates. You could
also take the page variable and just declare it inside that loop. The
use appears to be local there.
for (pfn = start_pfn; pfn < end_pfn; pfn++) {
struct page *page;
if (!early_pfn_valid(pfn))
continue;
if (!early_pfn_in_nid(pfn, nid))
continue;
page = pfn_to_page(pfn);
-- Dave
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-01-11 2:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-01-11 1:28 [PATCH] remove uneccesary page++ Greg Ungerer
2006-01-11 2:15 ` Dave Hansen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®