* [PATCH] Fix wireless build
@ 2006-01-11 3:17 Benjamin Herrenschmidt
2006-01-11 5:03 ` David S. Miller
0 siblings, 1 reply; 2+ messages in thread
From: Benjamin Herrenschmidt @ 2006-01-11 3:17 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Andrew Morton, Linux Kernel list
Current wireless core doesn't link here with a link error on
compare_ether_addr. The function exists, but is defined inline and the
wireless code forgets to #include the file containing the definition.
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Index: linux-work/net/core/wireless.c
===================================================================
--- linux-work.orig/net/core/wireless.c 2006-01-11 12:56:30.000000000 +1100
+++ linux-work/net/core/wireless.c 2006-01-11 14:14:27.000000000 +1100
@@ -78,7 +78,7 @@
#include <linux/seq_file.h>
#include <linux/init.h> /* for __init */
#include <linux/if_arp.h> /* ARPHRD_ETHER */
-
+#include <linux/etherdevice.h>
#include <linux/wireless.h> /* Pretty obvious */
#include <net/iw_handler.h> /* New driver API */
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix wireless build
2006-01-11 3:17 [PATCH] Fix wireless build Benjamin Herrenschmidt
@ 2006-01-11 5:03 ` David S. Miller
0 siblings, 0 replies; 2+ messages in thread
From: David S. Miller @ 2006-01-11 5:03 UTC (permalink / raw)
To: benh; +Cc: jgarzik, akpm, linux-kernel
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: Wed, 11 Jan 2006 14:17:32 +1100
> Current wireless core doesn't link here with a link error on
> compare_ether_addr. The function exists, but is defined inline and the
> wireless code forgets to #include the file containing the definition.
>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Sorry about that. Linus fixed it in his tree already, thanks
for the report.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-01-11 5:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-01-11 3:17 [PATCH] Fix wireless build Benjamin Herrenschmidt
2006-01-11 5:03 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®