mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Roland Dreier <rolandd@cisco.com>
To: linux-kernel@vger.kernel.org, openib-general@openib.org
Subject: [git patch review 2/4] IPoIB: Fix another send-only join race
Date: Sat, 11 Feb 2006 20:22:21 +0000	[thread overview]
Message-ID: <1139689341370-af4160238007a6e3@cisco.com> (raw)
In-Reply-To: <1139689341370-68b63fa9b8e76d91@cisco.com>

Further, there's an additional issue that I saw in testing:
ipoib_mcast_send may get called when priv->broadcast is NULL (e.g. if
the device was downed and then upped internally because of a port
event).

If this happends and the send-only join request gets completed before
priv->broadcast is set, we get an oops.

Signed-off-by: Michael S. Tsirkin <mst@mellanox.co.il>
Signed-off-by: Roland Dreier <rolandd@cisco.com>

---

 drivers/infiniband/ulp/ipoib/ipoib_multicast.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

7bcb974ef6a0ae903888272c92c66ea779388c01
diff --git a/drivers/infiniband/ulp/ipoib/ipoib_multicast.c b/drivers/infiniband/ulp/ipoib/ipoib_multicast.c
index 1c71482..932bf13 100644
--- a/drivers/infiniband/ulp/ipoib/ipoib_multicast.c
+++ b/drivers/infiniband/ulp/ipoib/ipoib_multicast.c
@@ -701,7 +701,7 @@ void ipoib_mcast_send(struct net_device 
 	 */
 	spin_lock(&priv->lock);
 
-	if (!test_bit(IPOIB_MCAST_STARTED, &priv->flags)) {
+	if (!test_bit(IPOIB_MCAST_STARTED, &priv->flags) || !priv->broadcast) {
 		++priv->stats.tx_dropped;
 		dev_kfree_skb_any(skb);
 		goto unlock;
-- 
1.1.3

  reply	other threads:[~2006-02-11 20:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-11 20:22 [git patch review 1/4] IPoIB: Don't start send-only joins while multicast thread is stopped Roland Dreier
2006-02-11 20:22 ` Roland Dreier [this message]
2006-02-11 20:22   ` [git patch review 3/4] IB/mthca: Don't print debugging info until we have all values Roland Dreier
2006-02-11 20:22     ` [git patch review 4/4] IPoIB: Yet another fix for send-only joins Roland Dreier
2006-02-11 22:02 ` [git patch review 1/4] IPoIB: Don't start send-only joins while multicast thread is stopped Andrew Morton
2006-02-12  2:03   ` Roland Dreier
2006-02-12  7:50     ` [openib-general] " Michael S. Tsirkin
2006-02-12  8:13       ` Kyle Moffett
2006-02-12  8:19         ` Michael S. Tsirkin
2006-02-12 16:37       ` [openib-general] " Roland Dreier
2006-02-12 16:56         ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1139689341370-af4160238007a6e3@cisco.com \
    --to=rolandd@cisco.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=openib-general@openib.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®