From: "Michael S. Tsirkin" <mst@mellanox.co.il>
To: Kyle Moffett <mrmacman_g4@mac.com>
Cc: Roland Dreier <rdreier@cisco.com>, Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, openib-general@openib.org
Subject: Re: Re: [git patch review 1/4] IPoIB: Don't start send-only joins while multicast thread is stopped
Date: Sun, 12 Feb 2006 10:19:10 +0200 [thread overview]
Message-ID: <20060212081910.GA11812@mellanox.co.il> (raw)
In-Reply-To: <BF4A90F5-149D-4627-A350-48CC4D214C28@mac.com>
Quoting r. Kyle Moffett <mrmacman_g4@mac.com>:
> On Feb 12, 2006, at 02:50, Michael S. Tsirkin wrote:
> >Basically, its as Andrew said: the lock around clear_bit is there
> >to ensure that ipoib_mcast_send isnt running already when we stop
> >the thread. Thats why test_bit has to be inside the lock, too.
>
> Looks like you guys could use nonatomic versions to improve bus
> efficiency slightly
I think we need atomics since other places touch bits in the same word without
taking the lock.
--
Michael S. Tsirkin
Staff Engineer, Mellanox Technologies
next prev parent reply other threads:[~2006-02-12 8:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-11 20:22 Roland Dreier
2006-02-11 20:22 ` [git patch review 2/4] IPoIB: Fix another send-only join race Roland Dreier
2006-02-11 20:22 ` [git patch review 3/4] IB/mthca: Don't print debugging info until we have all values Roland Dreier
2006-02-11 20:22 ` [git patch review 4/4] IPoIB: Yet another fix for send-only joins Roland Dreier
2006-02-11 22:02 ` [git patch review 1/4] IPoIB: Don't start send-only joins while multicast thread is stopped Andrew Morton
2006-02-12 2:03 ` Roland Dreier
2006-02-12 7:50 ` [openib-general] " Michael S. Tsirkin
2006-02-12 8:13 ` Kyle Moffett
2006-02-12 8:19 ` Michael S. Tsirkin [this message]
2006-02-12 16:37 ` Roland Dreier
2006-02-12 16:56 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060212081910.GA11812@mellanox.co.il \
--to=mst@mellanox.co.il \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mrmacman_g4@mac.com \
--cc=openib-general@openib.org \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®