From: Arjan van de Ven <arjan@infradead.org>
To: Jody McIntyre <scjody@modernduck.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
linux-kernel@vger.kernel.org,
linux1394-devel@lists.sourceforge.net
Subject: Re: [RFC 2/4] firewire: dynamic cdev allocation below firewire major
Date: Mon, 13 Feb 2006 08:32:21 +0100 [thread overview]
Message-ID: <1139815941.2997.9.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <20060213035150.GE3072@conscoop.ottawa.on.ca>
On Sun, 2006-02-12 at 22:51 -0500, Jody McIntyre wrote:
> On Thu, Feb 02, 2006 at 11:40:12PM +0100, Johannes Berg wrote:
> > This patch implements dynamic minor number allocation below the 171
> > major allocated for ieee1394. Since on today's systems one doesn't need
> > to have fixed device numbers any more we could just use any, but it's
> > probably still useful to use the ieee1394 major number for any firewire
> > related devices (like mem1394).
>
> I don't really like this. There's no benefit to using the 1394 major
> number. I'd rather see an improved alloc_chrdev_region() that does
> something like this but for the whole kernel (currently it "wastes" an
> entire major even if you only want 1 minor, and for what you're doing,
> grabbing 1 minor at a time makes the most sense.)
why bother? There's a LOT of majors nowadays (12 bits) so... what's the
problem with keeping the kernel side simple?
(it's not as if userspace needs to care about the exact numbers anyway
for almost everything)
next prev parent reply other threads:[~2006-02-13 7:32 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-02 22:27 [RFC 0/4] firewire: interface to remote memory (mem1394) Johannes Berg
2006-02-02 22:38 ` [RFC 1/4] firewire: node interface Johannes Berg
2006-02-02 22:40 ` [RFC 2/4] firewire: dynamic cdev allocation below firewire major Johannes Berg
2006-02-05 13:11 ` Stefan Richter
2006-02-13 3:51 ` Jody McIntyre
2006-02-13 7:32 ` Arjan van de Ven [this message]
2006-02-13 12:02 ` Johannes Berg
2006-02-13 16:49 ` Stefan Richter
2006-02-13 21:10 ` Arjan van de Ven
2006-02-14 15:41 ` Johannes Berg
2006-02-02 22:41 ` [RFC 3/4] firewire: unconditionally export hpsb_send_packet_and_wait Johannes Berg
2006-02-05 13:42 ` Stefan Richter
2006-02-07 10:45 ` Johannes Berg
2006-02-02 22:43 ` [RFC 4/4] firewire: add mem1394 Johannes Berg
2006-02-03 11:35 ` Andy Wingo
2006-02-03 11:47 ` Johannes Berg
2006-02-05 12:59 ` Stefan Richter
2006-02-05 8:43 ` Andrew Morton
2006-02-05 9:09 ` Kyle Moffett
[not found] ` <43E5D599.5040503@s5r6.in-berlin.de>
2006-02-05 20:09 ` Stefan Richter
2006-02-05 20:17 ` Andi Kleen
2006-02-05 20:50 ` Stefan Richter
2006-02-06 8:44 ` Andi Kleen
2006-02-05 14:19 ` Stefan Richter
2006-02-07 10:41 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1139815941.2997.9.camel@laptopd505.fenrus.org \
--to=arjan@infradead.org \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=scjody@modernduck.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®