From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: Marc Zyngier <marc.zyngier@arm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>,
open list <linux-kernel@vger.kernel.org>,
linux-arm-msm@vger.kernel.org, "Nayak,
Rajendra" <rnayak@codeaurora.org>,
bjorn.andersson@linaro.org, sboyd@kernel.org
Subject: Re: [PATCH] irqchip/gic-v3: do not access GICR_WAKER if its secured register.
Date: Wed, 13 Jun 2018 11:53:36 +0100 [thread overview]
Message-ID: <113cbfb5-9701-c62c-75c1-72c2dda8df8c@linaro.org> (raw)
In-Reply-To: <CAPKp9uYQC+Pw+DgdTny317s3sNcyE=Shthvyrh7wn0r=Qy1tSQ@mail.gmail.com>
On 13/06/18 09:45, Sudeep Holla wrote:
> On Wed, Jun 13, 2018 at 9:21 AM, Srinivas Kandagatla
> <srinivas.kandagatla@linaro.org> wrote:
>>
>>
>> On 12/06/18 17:34, Marc Zyngier wrote:
>>>
>>> I suggest you find out how the GIC has been integrated on this
>>> platform. If you take a fault on accessing this register, this very
>>> much looks like an integration bug, and it should be quirked as such.
>>
>> Thanks for the suggestion, This is a bug in the firmware which is
>> restricting access to this register. We have been working around this bug
>> for more than 2 years due to this. Now this platform support is in mainline
>> and We/I have no hope that this will be fixed in near future atleast for
>> this platform.
>>
>
> From what you are saying, you were aware of the firmware bug for 2 years as
> you had work-around from then. I wish the firmware had come up with the fix
> in those lost 2 years. I understand if it was discovered now, but that doesn't
> seem to be the case here.
>
> Firmware fixes are now becoming inevitable, so the attitude that firmware can't
> be fixed has to slowing change. I am not saying I am against the quirk, but in
> general I have seen the firmware support of QCOM parts are really bad. I waited
> for almost 2 years for PSCI firmware on previous dragonboard where developer
> are trying to upstream some feature.
I agree with you!
We did wait for more than 2 years for firmware to be fixed. But it never
happened and very little hopes to get it fixed.
I did try the quirk based on GICD_IIDR and I could boot linus master on
DB820c!
I will send it out as RFC soon.
thanks,
srini
>
> --
> Regards,
> Sudeep
>
prev parent reply other threads:[~2018-06-13 10:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-12 14:55 Srinivas Kandagatla
2018-06-12 15:24 ` Sudeep Holla
2018-06-12 15:51 ` Srinivas Kandagatla
2018-06-12 16:34 ` Marc Zyngier
2018-06-13 8:21 ` Srinivas Kandagatla
2018-06-13 8:45 ` Sudeep Holla
2018-06-13 10:53 ` Srinivas Kandagatla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=113cbfb5-9701-c62c-75c1-72c2dda8df8c@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=jason@lakedaemon.net \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=rnayak@codeaurora.org \
--cc=sboyd@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®