mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Jason Cooper <jason@lakedaemon.net>,
	Marc Zyngier <marc.zyngier@arm.com>,
	open list <linux-kernel@vger.kernel.org>,
	linux-arm-msm@vger.kernel.org, "Nayak,
	Rajendra" <rnayak@codeaurora.org>,
	bjorn.andersson@linaro.org, sboyd@kernel.org
Subject: Re: [PATCH] irqchip/gic-v3: do not access GICR_WAKER if its secured register.
Date: Tue, 12 Jun 2018 16:51:38 +0100	[thread overview]
Message-ID: <65400c1c-7575-cba8-0919-3f426bc71d4b@linaro.org> (raw)
In-Reply-To: <CAPKp9uaJK8AQPgqYCmVmpS0RsMBPGUAK_xXkHsNDg+2e3MygyQ@mail.gmail.com>



On 12/06/18 16:24, Sudeep Holla wrote:
> On Tue, Jun 12, 2018 at 3:55 PM, Srinivas Kandagatla
> <srinivas.kandagatla@linaro.org> wrote:
>> GICR_WAKER can be a secured register, check this before accessing it
>> as its done in power management code.
>>
>> Without this patch Qualcomm DB820c board crashes.
>>
> 
> Are you sure this is the one causing the crash ?
> 
Yep, am 100% sure its the write in gic_enable_redist(). Very first zero 
write to GICR_WAKER is the one which is crashing my system.

If I add return before writing then I can boot my system fine.

Not sure why writes are not ignored?

Also why does other parts of the code have checks while accessing this 
register?

thanks,
srini

> As per GIC specification:
> "When GICD_CTLR.DS==1, this register is always accessible.
>   When GICD_CTLR.DS==0, this is a Secure register. This register is RAZ/WI
>   to Non-secure accesses."
> 
> 
> --
> Regards,
> Sudeep
> 

  reply	other threads:[~2018-06-12 15:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-12 14:55 Srinivas Kandagatla
2018-06-12 15:24 ` Sudeep Holla
2018-06-12 15:51   ` Srinivas Kandagatla [this message]
2018-06-12 16:34 ` Marc Zyngier
2018-06-13  8:21   ` Srinivas Kandagatla
2018-06-13  8:45     ` Sudeep Holla
2018-06-13 10:53       ` Srinivas Kandagatla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=65400c1c-7575-cba8-0919-3f426bc71d4b@linaro.org \
    --to=srinivas.kandagatla@linaro.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=jason@lakedaemon.net \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=rnayak@codeaurora.org \
    --cc=sboyd@kernel.org \
    --cc=sudeep.holla@arm.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®