mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjan@infradead.org>
To: Hansjoerg Lipp <hjlipp@web.de>
Cc: Karsten Keil <kkeil@suse.de>,
	i4ldeveloper@listserv.isdn4linux.de,
	linux-usb-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, Greg Kroah-Hartman <gregkh@suse.de>,
	Tilman Schmidt <tilman@imap.cc>
Subject: Re: [PATCH 0/7] isdn4linux: add drivers for Siemens Gigaset ISDN DECT PABX
Date: Mon, 27 Feb 2006 10:29:37 +0100	[thread overview]
Message-ID: <1141032577.2992.83.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <gigaset307x.2006.02.27.001.0@hjlipp.my-fqdn.de>

On Mon, 2006-02-27 at 07:23 +0100, Hansjoerg Lipp wrote:
> The following patches add drivers for the Siemens Gigaset 3070 family of
> ISDN DECT PABXes connected via USB, either directly or over a DECT link
> using a Gigaset M105 or compatible DECT data adapter. The devices are
> integrated as ISDN adapters within the isdn4linux framework, supporting
> incoming and outgoing voice and data connections, and also as tty
> devices providing access to device specific AT commands.


as a general review remark: you seem to use a LOT of atomic variables.
This I think is not too good an approach in general, because you get
into all kinds of race situations if you need to access multiple (and
you do). In addition I've seen a lot of your code using 2 or more
atomics in the same function, at which point it's most likely cheaper to
just have a spinlock instead... (yes a single atomic is same cost as a
spinlock, but once you do multiple in the same function the price is
thus higher than a spinlock ;)



  parent reply	other threads:[~2006-02-27  9:29 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-27  6:23 Hansjoerg Lipp
2006-02-27  6:23 ` [PATCH 1/7] isdn4linux: Siemens Gigaset drivers - common module Hansjoerg Lipp
2006-02-27  6:23   ` [PATCH 2/7] isdn4linux: Siemens Gigaset drivers - event layer Hansjoerg Lipp
2006-02-27  6:23     ` [PATCH 3/7] isdn4linux: Siemens Gigaset drivers - subsystem interfaces Hansjoerg Lipp
2006-02-27  6:23       ` [PATCH 4/7] isdn4linux: Siemens Gigaset drivers - direct USB connection Hansjoerg Lipp
2006-02-27  6:23         ` [PATCH 5/7] isdn4linux: Siemens Gigaset drivers - isochronous data handler Hansjoerg Lipp
2006-02-27  6:23           ` [PATCH 6/7] isdn4linux: Siemens Gigaset drivers - M105 USB DECT adapter Hansjoerg Lipp
2006-02-27  6:23             ` [PATCH 7/7] isdn4linux: Siemens Gigaset drivers - Kconfigs and Makefiles Hansjoerg Lipp
2006-02-27  8:01     ` [PATCH 2/7] isdn4linux: Siemens Gigaset drivers - event layer Arjan van de Ven
2006-02-27  8:02     ` Arjan van de Ven
2006-02-27  7:52   ` [PATCH 1/7] isdn4linux: Siemens Gigaset drivers - common module Arjan van de Ven
2006-02-27  8:00   ` Arjan van de Ven
2006-02-27  9:29 ` Arjan van de Ven [this message]
2006-03-02 23:03   ` [PATCH 0/7] isdn4linux: add drivers for Siemens Gigaset ISDN DECT PABX Tilman Schmidt
2006-03-03  0:58     ` Roland Dreier
2006-03-03  6:53     ` Arjan van de Ven
2006-03-03  9:44       ` Karsten Keil
2006-03-03 14:54       ` Tilman Schmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1141032577.2992.83.camel@laptopd505.fenrus.org \
    --to=arjan@infradead.org \
    --cc=gregkh@suse.de \
    --cc=hjlipp@web.de \
    --cc=i4ldeveloper@listserv.isdn4linux.de \
    --cc=kkeil@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb-devel@lists.sourceforge.net \
    --cc=tilman@imap.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®