From: Karsten Keil <kkeil@suse.de>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Tilman Schmidt <tilman@imap.cc>, Hansjoerg Lipp <hjlipp@web.de>,
i4ldeveloper@listserv.isdn4linux.de,
linux-usb-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, Greg Kroah-Hartman <gregkh@suse.de>
Subject: Re: [PATCH 0/7] isdn4linux: add drivers for Siemens Gigaset ISDN DECT PABX
Date: Fri, 3 Mar 2006 10:44:30 +0100 [thread overview]
Message-ID: <20060303094430.GB31772@pingi.kke.suse.de> (raw)
In-Reply-To: <1141368808.2883.16.camel@laptopd505.fenrus.org>
On Fri, Mar 03, 2006 at 07:53:28AM +0100, Arjan van de Ven wrote:
> On Fri, 2006-03-03 at 00:03 +0100, Tilman Schmidt wrote:
...
>
> > >>+#define IFNULL(a) \
> > >>+ if (unlikely(!(a)))
> > >
> > > please please get rid of this!
> > > (same goes for the variants of this just below this)
> >
> > Ok, these were mainly debugging aids. We'll just drop them and let the
> > oops mechanism catch the (hopefully non-existent) remaining cases of
> > pointers being unexpectedly NULL.
>
> you can also use WARN_ON() and BUG_ON() for that, you then get a more
> readable oops message (with filename and line information)
>
Yes, but please only WARN_ON(), BUG_ON should be only used, if here is no
way to recover or if continue will cause major data corruption, I do not
think thats the case anywhere in the driver.
--
Karsten Keil
SuSE Labs
ISDN development
next prev parent reply other threads:[~2006-03-03 9:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-27 6:23 Hansjoerg Lipp
2006-02-27 6:23 ` [PATCH 1/7] isdn4linux: Siemens Gigaset drivers - common module Hansjoerg Lipp
2006-02-27 6:23 ` [PATCH 2/7] isdn4linux: Siemens Gigaset drivers - event layer Hansjoerg Lipp
2006-02-27 6:23 ` [PATCH 3/7] isdn4linux: Siemens Gigaset drivers - subsystem interfaces Hansjoerg Lipp
2006-02-27 6:23 ` [PATCH 4/7] isdn4linux: Siemens Gigaset drivers - direct USB connection Hansjoerg Lipp
2006-02-27 6:23 ` [PATCH 5/7] isdn4linux: Siemens Gigaset drivers - isochronous data handler Hansjoerg Lipp
2006-02-27 6:23 ` [PATCH 6/7] isdn4linux: Siemens Gigaset drivers - M105 USB DECT adapter Hansjoerg Lipp
2006-02-27 6:23 ` [PATCH 7/7] isdn4linux: Siemens Gigaset drivers - Kconfigs and Makefiles Hansjoerg Lipp
2006-02-27 8:01 ` [PATCH 2/7] isdn4linux: Siemens Gigaset drivers - event layer Arjan van de Ven
2006-02-27 8:02 ` Arjan van de Ven
2006-02-27 7:52 ` [PATCH 1/7] isdn4linux: Siemens Gigaset drivers - common module Arjan van de Ven
2006-02-27 8:00 ` Arjan van de Ven
2006-02-27 9:29 ` [PATCH 0/7] isdn4linux: add drivers for Siemens Gigaset ISDN DECT PABX Arjan van de Ven
2006-03-02 23:03 ` Tilman Schmidt
2006-03-03 0:58 ` Roland Dreier
2006-03-03 6:53 ` Arjan van de Ven
2006-03-03 9:44 ` Karsten Keil [this message]
2006-03-03 14:54 ` Tilman Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060303094430.GB31772@pingi.kke.suse.de \
--to=kkeil@suse.de \
--cc=arjan@infradead.org \
--cc=gregkh@suse.de \
--cc=hjlipp@web.de \
--cc=i4ldeveloper@listserv.isdn4linux.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=tilman@imap.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®