From: Arjan van de Ven <arjan@infradead.org>
To: minyard@acm.org
Cc: greg@kroah.com, Linux Kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>,
Yani Ioannou <yani.ioannou@gmail.com>
Subject: Re: [PATCH 2/2] Add full sysfs support to the IPMI driver
Date: Wed, 22 Mar 2006 10:01:09 +0100 [thread overview]
Message-ID: <1143018069.2955.43.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <20060321221328.GB27436@i2.minyard.local>
On Tue, 2006-03-21 at 16:13 -0600, Corey Minyard wrote:
> +static void ipmi_bmc_release(struct device *dev)
> +{
> + printk(KERN_DEBUG "ipmi_bmc release\n");
> +}
eehhhh NO.
Please read the many comments and documentations about why a release
function is NOT allowed to be empty. In fact the kernel warned you about
that, didn't it?
next prev parent reply other threads:[~2006-03-22 9:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-21 22:13 Corey Minyard
2006-03-22 9:01 ` Arjan van de Ven [this message]
2006-03-22 20:47 ` Greg KH
2006-03-22 20:59 ` Al Viro
2006-03-22 21:29 ` Corey Minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1143018069.2955.43.camel@laptopd505.fenrus.org \
--to=arjan@infradead.org \
--cc=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
--cc=yani.ioannou@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®