From: Dave Hansen <haveblue@us.ibm.com>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] X86_NUMAQ build fix
Date: Fri, 21 Apr 2006 11:59:48 -0700 [thread overview]
Message-ID: <1145645988.3373.38.camel@localhost.localdomain> (raw)
In-Reply-To: <874q0mwyor.fsf@duaron.myhome.or.jp>
On Sat, 2006-04-22 at 03:50 +0900, OGAWA Hirofumi wrote:
> Dave Hansen <haveblue@us.ibm.com> writes:
> >> pci-y := fixup.o
> >> -pci-$(CONFIG_ACPI) += acpi.o
> >> pci-y += legacy.o irq.o
> >>
> >> pci-$(CONFIG_X86_VISWS) := visws.o fixup.o
> >> pci-$(CONFIG_X86_NUMAQ) := numa.o irq.o
> >>
> >> +pci-$(CONFIG_ACPI) += acpi.o
> >
> > Am I reading this wrong, or does this just move the option down a bit?
> > Did you need to change the link order? Why?
>
> No, this is not link order. Note that CONFIG_X86_VISWS/CONFIG_X86_NUMAQ
> uses ":=", not "+=". In case of ACPI=y", it breaks build.
Ahh, so NUMAQ and VISWS don't seem to allow or want ACPI code.
Especially for the NUMAQ, I don't think we should even mess with this
too much. Just fix it in the build system and directly disallow NUMAQ
&& ACPI.
We already have this:
menu "ACPI (Advanced Configuration and Power Interface) Support"
depends on !X86_VISWS
Just add the NUMAQ in there, too.
-- Dave
next prev parent reply other threads:[~2006-04-21 19:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-21 16:06 OGAWA Hirofumi
2006-04-21 18:19 ` Dave Hansen
2006-04-21 18:50 ` OGAWA Hirofumi
2006-04-21 18:59 ` Dave Hansen [this message]
2006-04-21 19:31 ` OGAWA Hirofumi
2006-04-21 19:36 ` Dave Hansen
2006-04-21 20:03 ` OGAWA Hirofumi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1145645988.3373.38.camel@localhost.localdomain \
--to=haveblue@us.ibm.com \
--cc=akpm@osdl.org \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®