From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Dave Hansen <haveblue@us.ibm.com>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] X86_NUMAQ build fix
Date: Sat, 22 Apr 2006 05:03:40 +0900 [thread overview]
Message-ID: <87lktyvgpv.fsf@duaron.myhome.or.jp> (raw)
In-Reply-To: <1145648166.3373.41.camel@localhost.localdomain> (Dave Hansen's message of "Fri, 21 Apr 2006 12:36:05 -0700")
Dave Hansen <haveblue@us.ibm.com> writes:
> Do you really need anything other than the Kconfig fix? I thought that
> it alone would be a complete fix.
Yes. I thought I explained those...
> #ifdef CONFIG_X86_NUMAQ
> -static void * xquad_portio = NULL;
> +/* hack to avoid using xquad_portio=NULL */
> +#undef outb_p
> +#define outb_p outb_local_p
> #endif
This fixes the following error.
make -C /devel/linux/works/linux-2.6 O=/devel/linux/works/linux-2.6-devron
GEN /devel/linux/works/linux-2.6-devron/Makefile
CHK include/linux/version.h
Using /devel/linux/works/linux-2.6 as source for kernel
CHK include/linux/compile.h
LD vmlinux
SYSMAP System.map
SYSMAP .tmp_System.map
Building modules, stage 2.
LD arch/i386/boot/setup
CC arch/i386/boot/compressed/misc.o
OBJCOPY arch/i386/boot/compressed/vmlinux.bin
GZIP arch/i386/boot/compressed/vmlinux.bin.gz
/devel/linux/works/linux-2.6/arch/i386/boot/compressed/misc.c:125: error: static declaration of 'xquad_portio' follows non-static declaration
include2/asm/io.h:303: error: previous declaration of 'xquad_portio' was here
make[4]: *** [arch/i386/boot/compressed/misc.o] Error 1
make[4]: *** Waiting for unfinished jobs....
MODPOST
make[3]: *** [arch/i386/boot/compressed/vmlinux] Error 2
make[2]: *** [bzImage] Error 2
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [_all] Error 2
make: *** [all] Error 2
> static int boot_cpu_logical_apicid;
> +#ifdef CONFIG_X86_NUMAQ
> /* Where the IO area was mapped on multiquad, always 0 otherwise */
> void *xquad_portio;
> -#ifdef CONFIG_X86_NUMAQ
> EXPORT_SYMBOL(xquad_portio);
> #endif
xquad_portio is needed to only X86_NUMAQ.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
prev parent reply other threads:[~2006-04-21 20:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-21 16:06 OGAWA Hirofumi
2006-04-21 18:19 ` Dave Hansen
2006-04-21 18:50 ` OGAWA Hirofumi
2006-04-21 18:59 ` Dave Hansen
2006-04-21 19:31 ` OGAWA Hirofumi
2006-04-21 19:36 ` Dave Hansen
2006-04-21 20:03 ` OGAWA Hirofumi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lktyvgpv.fsf@duaron.myhome.or.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=akpm@osdl.org \
--cc=haveblue@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®