mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: Hugh Dickins <hugh@veritas.com>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>,
	Mikael Starvik <mikael.starvik@axis.com>,
	akpm@osdl.org, andrea@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Shrink rbtree
Date: Fri, 21 Apr 2006 23:12:53 +0100	[thread overview]
Message-ID: <1145657573.11909.226.camel@pmac.infradead.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0604212150270.9101@blonde.wat.veritas.com>

On Fri, 2006-04-21 at 21:57 +0100, Hugh Dickins wrote:
> 
> } __attribute__((aligned(sizeof(long))));
>         /*
>          * On most architectures that alignment is already the case; but
>          * must be enforced here for CRIS, to let the least signficant bit
>          * of struct page's "mapping" pointer be used for PAGE_MAPPING_ANON.
>          */
> 
> You can often get away with it - I notice we never added the same
> alignment to struct anon_vma, which in theory needed it just as much.
> Some accident of how structures are packed into slabs on CRIS, I suppose.

That sounds very strange to me, but it's harmless enough to add the
explicit alignment.

-- 
dwmw2


  reply	other threads:[~2006-04-21 22:13 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-21 12:47 David Woodhouse
2006-04-21 13:06 ` Nick Piggin
2006-04-21 19:08   ` David Woodhouse
2006-04-21 20:57     ` Hugh Dickins
2006-04-21 22:12       ` David Woodhouse [this message]
2006-04-23 13:03         ` Hugh Dickins
2006-04-21 18:24 ` Zach Brown
2006-04-21 19:06   ` David Woodhouse
2006-04-21 19:25     ` Zach Brown
2006-04-22  1:09 ` Andrew Morton
2006-04-22  1:10   ` Andrew Morton
2006-04-22  1:21     ` Andrew Morton
2006-04-22  1:29   ` David Woodhouse
2006-04-22 12:29     ` Ingo Oeser
2006-04-22 13:38       ` David Woodhouse
2006-04-22 22:55         ` Ingo Oeser
2006-04-23 16:36   ` Steven Rostedt
2006-04-23 17:20     ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1145657573.11909.226.camel@pmac.infradead.org \
    --to=dwmw2@infradead.org \
    --cc=akpm@osdl.org \
    --cc=andrea@suse.de \
    --cc=hugh@veritas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikael.starvik@axis.com \
    --cc=nickpiggin@yahoo.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®