mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Oeser <ioe-lkml@rameria.de>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Andrew Morton <akpm@osdl.org>,
	andrea@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Shrink rbtree
Date: Sun, 23 Apr 2006 00:55:55 +0200	[thread overview]
Message-ID: <200604230055.56207.ioe-lkml@rameria.de> (raw)
In-Reply-To: <1145713139.11909.262.camel@pmac.infradead.org>

Hio David,

On Saturday, 22. April 2006 15:38, David Woodhouse wrote:
> I'm reluctant to 'bless' this practice, because we'll then get asked to
> set it to 'inactive' every time we take a node off the tree, to have a
> BUG_ON() which checks it in certain places, etc.... it's mostly
> pointless AFAICT.

I understand your point. Can we agree on just doing this for functions which
are handed off-tree and on-tree nodes and have to care for locking reasons?

It is ok for functions to enforce their API with BUG_ON(). But this part should
not be generalized, since this part really depends on the user.

Each rbtree user having its own private hackery for this is wasted developer
resources IMHO. 

So please either provide common helpers or just delete the potential users
if you think this is not needed.

I'm happy either way.


Regards

Ingo Oeser

  reply	other threads:[~2006-04-22 22:58 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-21 12:47 David Woodhouse
2006-04-21 13:06 ` Nick Piggin
2006-04-21 19:08   ` David Woodhouse
2006-04-21 20:57     ` Hugh Dickins
2006-04-21 22:12       ` David Woodhouse
2006-04-23 13:03         ` Hugh Dickins
2006-04-21 18:24 ` Zach Brown
2006-04-21 19:06   ` David Woodhouse
2006-04-21 19:25     ` Zach Brown
2006-04-22  1:09 ` Andrew Morton
2006-04-22  1:10   ` Andrew Morton
2006-04-22  1:21     ` Andrew Morton
2006-04-22  1:29   ` David Woodhouse
2006-04-22 12:29     ` Ingo Oeser
2006-04-22 13:38       ` David Woodhouse
2006-04-22 22:55         ` Ingo Oeser [this message]
2006-04-23 16:36   ` Steven Rostedt
2006-04-23 17:20     ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200604230055.56207.ioe-lkml@rameria.de \
    --to=ioe-lkml@rameria.de \
    --cc=akpm@osdl.org \
    --cc=andrea@suse.de \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®