From: David Woodhouse <dwmw2@infradead.org>
To: Adrian Bunk <bunk@stusta.de>
Cc: linux-kernel@vger.kernel.org, sam@ravnborg.org
Subject: Re: [PATCH] 'make headers_install' kbuild target.
Date: Sat, 22 Apr 2006 14:36:04 +0100 [thread overview]
Message-ID: <1145712964.11909.258.camel@pmac.infradead.org> (raw)
In-Reply-To: <20060422132032.GB5010@stusta.de>
On Sat, 2006-04-22 at 15:20 +0200, Adrian Bunk wrote:
> Why can't the splitting happen incrementally?
It can, and has already started that way. There's no reason why the
'make headers_export' mechanism can't work with that -- it already does,
because it exports the include/mtd directory and nothing from
include/linux/mtd -- as I said, ideally the mechanism ends up being just
'cp -a' on certain directories. And then it can be abolished. We've got
a long way to go before we get there, though.
> Assume you have a header include/linux/foo.h:
> - Add an #include <kabi/linux/foo.h> at the top.
> - Move the part of the contents that is part of the userspace ABI to
> include/kabi/linux/foo.h.
Absolutely. That's what I've done with MTD headers already, although the
directory names are different. The directory names don't _matter_
either, because important part was that the files themselves are cleaned
up.
Linus isn't keen on splitting it into a new directory, and I don't want
to start off by demanding that. As I said, the important part of the
above is the bit where one of us goes to the file with an editor and
identifies the public parts vs. the private parts, then splits them up
-- possibly with #ifdef __KERNEL__, but _preferably_ into separate
files. And it doesn't _matter_ which directories we put those files
into, for now. I don't want to talk about it _yet_ because it's just
taking attention away from the real problem.
The more we screw around with such minutiae, the less likely we are to
get traction with Linus -- despite the fact that almost everyone who's
expressed an opinion is _agreeing_ with you about where we want to end
up.
We need to keep it simple and unintrusive to start with. Concentrate on
the _contents_ and then we can deal with the less important details
later.
--
dwmw2
next prev parent reply other threads:[~2006-04-22 19:52 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-22 2:17 David Woodhouse
2006-04-22 9:33 ` Adrian Bunk
2006-04-22 12:03 ` David Woodhouse
2006-04-22 12:38 ` Adrian Bunk
2006-04-22 12:48 ` David Woodhouse
2006-04-22 13:20 ` Adrian Bunk
2006-04-22 13:36 ` David Woodhouse [this message]
2006-04-22 14:11 ` Adrian Bunk
2006-04-22 14:26 ` David Woodhouse
2006-04-22 14:44 ` Adrian Bunk
2006-04-22 14:56 ` David Woodhouse
2006-04-22 15:30 ` David Woodhouse
2006-04-22 21:13 ` Arnd Bergmann
2006-04-23 7:09 ` Arjan van de Ven
2006-04-23 16:51 ` Arnd Bergmann
2006-04-23 17:00 ` Joshua Hudson
2006-04-22 14:14 ` Sam Ravnborg
2006-04-22 14:20 ` Adrian Bunk
2006-04-22 14:28 ` Sam Ravnborg
2006-04-22 14:47 ` David Woodhouse
2006-04-22 14:50 ` Adrian Bunk
2006-04-28 18:15 ` Rob Landley
2006-04-28 18:27 ` David Woodhouse
2006-04-28 19:59 ` Rob Landley
2006-04-22 14:35 ` David Woodhouse
2006-04-23 20:47 ` David Woodhouse
2006-04-24 0:12 ` David Woodhouse
2006-04-28 18:13 ` Rob Landley
2006-04-28 18:22 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1145712964.11909.258.camel@pmac.infradead.org \
--to=dwmw2@infradead.org \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®