From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Xin Zhao <uszhaoxin@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: question about nfs_execute_read: why do we need to do lock_kernel?
Date: Tue, 25 Apr 2006 10:26:49 -0400 [thread overview]
Message-ID: <1145975209.8193.35.camel@lade.trondhjem.org> (raw)
In-Reply-To: <4ae3c140604250708w438545c1lfa66233fdaa63cc@mail.gmail.com>
On Tue, 2006-04-25 at 10:08 -0400, Xin Zhao wrote:
> Thanks for your reply. So the only reason is for rpc auditing? If so,
> why not just lock the code that updating the audit information? Now
> the code is:
No. You misunderstood me.
I said that we need to audit the _code_ for races.
In the distant past, the rpc code was entirely protected by the BKL
against concurrent access to shared objects (queues, structures,
variables etc). Today, most of those shared objects have been given
their own locks, but nobody has yet gone through the code line by line
in order to check that it is safe to remove the BKL.
Cheers,
Trond
next prev parent reply other threads:[~2006-04-25 14:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-25 4:57 Xin Zhao
2006-04-25 5:09 ` Trond Myklebust
2006-04-25 14:08 ` Xin Zhao
2006-04-25 14:26 ` Trond Myklebust [this message]
2006-04-25 14:37 ` Peter Staubach
2006-04-25 15:31 ` Xin Zhao
2006-04-25 15:57 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1145975209.8193.35.camel@lade.trondhjem.org \
--to=trond.myklebust@fys.uio.no \
--cc=linux-kernel@vger.kernel.org \
--cc=uszhaoxin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®