mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Xin Zhao <uszhaoxin@gmail.com>
Cc: Peter Staubach <staubach@redhat.com>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: question about nfs_execute_read: why do we need to do lock_kernel?
Date: Tue, 25 Apr 2006 11:57:21 -0400	[thread overview]
Message-ID: <1145980641.8193.97.camel@lade.trondhjem.org> (raw)
In-Reply-To: <4ae3c140604250831v5a2f8714h7ab0beccba466da4@mail.gmail.com>

On Tue, 2006-04-25 at 11:31 -0400, Xin Zhao wrote:
> Thanks for your guys' reply!
> 
> Peter, can you point me somewhere I can check the semantics of BKL? In
> the past, I remembered BKL does block the kernel. So I am quite
> confused now.

That would have been true >10 years ago, when Alan introduced it.
Nowadays, the BKL is just another type of lock, albeit with very unique
properties. The two main ones being:
        - it can be taken recursively.
        - you can call schedule() while holding it.
                Note however, that upon yielding, the process
                automatically gives up the lock, then retakes it when it
                is rescheduled

> Also, I still don't understand why we use lock_kernel instead of some
> finer granularity lock. Trond's answer gave me a feeling that this is
> simply because the code is not carefully optimized.  :)

Sigh... Removing the BKL is not a trivial thing to do. You have make
absolutely sure that you understand the thread data dependencies that
are protected by that lock. That is why we do it gradually.

Cheers,
  Trond


      reply	other threads:[~2006-04-25 15:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-25  4:57 Xin Zhao
2006-04-25  5:09 ` Trond Myklebust
2006-04-25 14:08   ` Xin Zhao
2006-04-25 14:26     ` Trond Myklebust
2006-04-25 14:37     ` Peter Staubach
2006-04-25 15:31       ` Xin Zhao
2006-04-25 15:57         ` Trond Myklebust [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1145980641.8193.97.camel@lade.trondhjem.org \
    --to=trond.myklebust@fys.uio.no \
    --cc=linux-kernel@vger.kernel.org \
    --cc=staubach@redhat.com \
    --cc=uszhaoxin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®