From: Arjan van de Ven <arjan@infradead.org>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Hua Zhong <hzhong@gmail.com>,
linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [PATCH] likely cleanup: remove unlikely for kfree(NULL)
Date: Wed, 26 Apr 2006 09:58:44 +0200 [thread overview]
Message-ID: <1146038324.5956.0.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <84144f020604260030v26f42b0bke639053928d5e471@mail.gmail.com>
On Wed, 2006-04-26 at 10:30 +0300, Pekka Enberg wrote:
> On 4/25/06, Hua Zhong <hzhong@gmail.com> wrote:
> > diff --git a/mm/slab.c b/mm/slab.c
> > index e6ef9bd..0fbc854 100644
> > --- a/mm/slab.c
> > +++ b/mm/slab.c
> > @@ -3380,7 +3380,7 @@ void kfree(const void *objp)
> > struct kmem_cache *c;
> > unsigned long flags;
> >
> > - if (unlikely(!objp))
> > + if (!objp)
> > return;
>
> NAK. Fix the callers instead.
eh dude... they are being fixed... to remove the NULL check :)
next prev parent reply other threads:[~2006-04-26 7:58 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-25 18:21 Hua Zhong
2006-04-26 7:30 ` Pekka Enberg
2006-04-26 7:53 ` Andreas Mohr
2006-04-26 7:58 ` Arjan van de Ven [this message]
2006-04-26 8:16 ` Pekka J Enberg
2006-04-26 8:27 ` Arjan van de Ven
2006-04-26 10:05 ` Adrian Bunk
2006-04-26 10:05 ` Jörn Engel
2006-04-26 10:08 ` Arjan van de Ven
2006-04-26 10:57 ` Pekka J Enberg
2006-04-26 11:03 ` Arjan van de Ven
2006-04-26 11:06 ` Jörn Engel
2006-04-26 11:37 ` Bart Hartgers
2006-04-26 13:04 ` Bart Hartgers
2006-04-26 19:07 ` Kyle Moffett
2006-04-27 6:28 ` Pekka J Enberg
2006-04-27 6:37 ` Nick Piggin
2006-04-27 8:17 ` Bart Hartgers
2006-04-27 15:23 ` Kyle Moffett
2006-04-26 14:11 ` Pekka J Enberg
2006-04-27 5:54 ` Pekka J Enberg
2006-04-27 6:17 ` Nick Piggin
2006-04-27 6:28 ` Pekka J Enberg
2006-04-27 6:50 ` Arjan van de Ven
2006-04-27 8:31 ` Adrian Bunk
2006-04-27 8:41 ` Arjan van de Ven
2006-04-27 8:56 ` Adrian Bunk
2006-04-27 9:08 ` Arjan van de Ven
2006-04-27 11:41 ` Bart Hartgers
2006-04-27 18:23 ` Adrian Bunk
2006-04-27 18:29 ` Arjan van de Ven
2006-04-26 11:05 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1146038324.5956.0.camel@laptopd505.fenrus.org \
--to=arjan@infradead.org \
--cc=akpm@osdl.org \
--cc=hzhong@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®