mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjan@infradead.org>
To: Adrian Bunk <bunk@stusta.de>
Cc: "Pekka J Enberg" <penberg@cs.Helsinki.FI>,
	"Nick Piggin" <nickpiggin@yahoo.com.au>,
	"Jörn Engel" <joern@wohnheim.fh-wedel.de>,
	"Hua Zhong" <hzhong@gmail.com>,
	linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [PATCH] likely cleanup: remove unlikely for kfree(NULL)
Date: Thu, 27 Apr 2006 11:08:05 +0200	[thread overview]
Message-ID: <1146128885.2894.27.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <20060427085614.GE3570@stusta.de>

On Thu, 2006-04-27 at 10:56 +0200, Adrian Bunk wrote:
> On Thu, Apr 27, 2006 at 10:41:12AM +0200, Arjan van de Ven wrote:
> > On Thu, 2006-04-27 at 10:31 +0200, Adrian Bunk wrote:
> > > On Thu, Apr 27, 2006 at 08:50:40AM +0200, Arjan van de Ven wrote:
> > > > On Thu, 2006-04-27 at 09:28 +0300, Pekka J Enberg wrote:
> > > > > On Thu, 27 Apr 2006, Nick Piggin wrote:
> > > > > > Not to dispute your conclusions or method, but I think doing a
> > > > > > defconfig or your personal config might be more representative
> > > > > > of % size increase of text that will actually be executed. And
> > > > > > that is the expensive type of text.
> > > > > 
> > > > > True but I was under the impression that Arjan thought we'd get text 
> > > > > savings with GCC 4.1 by making kfree() inline.
> > > > 
> > > > not savings in text size, I'll settle for the same size.
> > > >...
> > > 
> > > It will always be bigger since there are cases where it's unknown at 
> > > compile time whether it will be NULL when called.
> > 
> > if it's "unknown" you could call into a separate kfree() which does
> > check out of line. (sure that's a dozen bytes bigger but that is
> > noise ;)
> 
> It's noise and _much work.

not if the compiler can do it. The *compiler* knows a lot (4.1 at
least)..


  reply	other threads:[~2006-04-27  9:08 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-25 18:21 Hua Zhong
2006-04-26  7:30 ` Pekka Enberg
2006-04-26  7:53   ` Andreas Mohr
2006-04-26  7:58   ` Arjan van de Ven
2006-04-26  8:16     ` Pekka J Enberg
2006-04-26  8:27       ` Arjan van de Ven
2006-04-26 10:05         ` Adrian Bunk
2006-04-26 10:05         ` Jörn Engel
2006-04-26 10:08           ` Arjan van de Ven
2006-04-26 10:57             ` Pekka J Enberg
2006-04-26 11:03               ` Arjan van de Ven
2006-04-26 11:06                 ` Jörn Engel
2006-04-26 11:37                   ` Bart Hartgers
2006-04-26 13:04                     ` Bart Hartgers
2006-04-26 19:07                       ` Kyle Moffett
2006-04-27  6:28                         ` Pekka J Enberg
2006-04-27  6:37                           ` Nick Piggin
2006-04-27  8:17                         ` Bart Hartgers
2006-04-27 15:23                           ` Kyle Moffett
2006-04-26 14:11                   ` Pekka J Enberg
2006-04-27  5:54                   ` Pekka J Enberg
2006-04-27  6:17                     ` Nick Piggin
2006-04-27  6:28                       ` Pekka J Enberg
2006-04-27  6:50                         ` Arjan van de Ven
2006-04-27  8:31                           ` Adrian Bunk
2006-04-27  8:41                             ` Arjan van de Ven
2006-04-27  8:56                               ` Adrian Bunk
2006-04-27  9:08                                 ` Arjan van de Ven [this message]
2006-04-27 11:41                                   ` Bart Hartgers
2006-04-27 18:23                                   ` Adrian Bunk
2006-04-27 18:29                                     ` Arjan van de Ven
2006-04-26 11:05               ` Nick Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1146128885.2894.27.camel@laptopd505.fenrus.org \
    --to=arjan@infradead.org \
    --cc=akpm@osdl.org \
    --cc=bunk@stusta.de \
    --cc=hzhong@gmail.com \
    --cc=joern@wohnheim.fh-wedel.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nickpiggin@yahoo.com.au \
    --cc=penberg@cs.Helsinki.FI \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®