From: John McCutchan <john@johnmccutchan.com>
To: Amy Griffis <amy.griffis@hp.com>
Cc: linux-kernel@vger.kernel.org, Robert Love <rlove@rlove.org>
Subject: Re: [PATCH] fix race in inotify_release
Date: Tue, 16 May 2006 15:54:40 -0400 [thread overview]
Message-ID: <BAYC1-PASMTP11E93E051D25687C02443DB9A00@CEZ.ICE> (raw)
Message-ID: <1147809280.2752.0.camel@localhost.localdomain> (raw)
In-Reply-To: <20060516193941.GA27045@zk3.dec.com>
On Tue, 2006-05-16 at 15:39 -0400, Amy Griffis wrote:
> While doing some inotify stress testing, I hit the following race. In
> inotify_release(), it's possible for a watch to be removed from the
> lists in between dropping dev->mutex and taking inode->inotify_mutex.
> The reference we hold prevents the watch from being freed, but not
> from being removed.
>
> Checking the dev's idr mapping will prevent a double list_del of the
> same watch.
Looks good. Thanks for the patch and stress testing inotify!
--
John McCutchan <john@johnmccutchan.com>
prev parent reply other threads:[~2006-05-16 19:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-16 19:39 Amy Griffis
[not found] ` <1147809280.2752.0.camel@localhost.localdomain>
2006-05-16 19:54 ` John McCutchan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BAYC1-PASMTP11E93E051D25687C02443DB9A00@CEZ.ICE \
--to=john@johnmccutchan.com \
--cc=amy.griffis@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rlove@rlove.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®