mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kylene Jo Hall <kjhall@us.ibm.com>
To: linux-kernel <linux-kernel@vger.kernel.org>
Cc: akpm@osdl.org,
	TPM Device Driver List <tpmdd-devel@lists.sourceforge.net>,
	Michael Prokop <prokop@sbox.tugraz.at>,
	Seiji Munetoh <MUNETOH@jp.ibm.com>,
	Leendert Van Doorn <leendert@us.ibm.com>
Subject: [PATCH] tpm: fix bug for TPM on ThinkPad T60 and Z60
Date: Thu, 25 May 2006 14:38:16 -0500	[thread overview]
Message-ID: <1148585896.5317.189.camel@localhost.localdomain> (raw)

The TPM chip on the ThinkPad T60 and Z60 machines is returning 0xFFFF
for the vendor ID which is a check the driver made to double check it
was actually talking to the memory mapped space of a TPM.  This patch
removes the check since it isn't absolutely necessary and was causing
device discovery to fail on these machines.

This bug fix should go into 2.6.17.

Signed-off-by: Kylene Hall <kjhall@us.ibm.com>
--- 
 tpm_tis.c |    4 ----
 1 files changed, 4 deletions(-)

--- linux-2.6.17-rc3/drivers/char/tpm/tpm_tis.c	2006-05-16 12:33:36.434356500 -0500
+++ linux-2.6.17-rc3-tpm/drivers/char/tpm/tpm_tis.c	2006-05-25 14:52:01.793058750 -0500
@@ -457,10 +457,6 @@ static int __devinit tpm_tis_pnp_init(st
 	}
 
 	vendor = ioread32(chip->vendor.iobase + TPM_DID_VID(0));
-	if ((vendor & 0xFFFF) == 0xFFFF) {
-		rc = -ENODEV;
-		goto out_err;
-	}
 
 	/* Default timeouts */
 	chip->vendor.timeout_a = msecs_to_jiffies(TIS_SHORT_TIMEOUT);




                 reply	other threads:[~2006-05-25 19:40 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1148585896.5317.189.camel@localhost.localdomain \
    --to=kjhall@us.ibm.com \
    --cc=MUNETOH@jp.ibm.com \
    --cc=akpm@osdl.org \
    --cc=leendert@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=prokop@sbox.tugraz.at \
    --cc=tpmdd-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®