mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] tpm: fix bug for TPM on ThinkPad T60 and Z60
@ 2006-05-25 19:38 Kylene Jo Hall
  0 siblings, 0 replies; only message in thread
From: Kylene Jo Hall @ 2006-05-25 19:38 UTC (permalink / raw)
  To: linux-kernel
  Cc: akpm, TPM Device Driver List, Michael Prokop, Seiji Munetoh,
	Leendert Van Doorn

The TPM chip on the ThinkPad T60 and Z60 machines is returning 0xFFFF
for the vendor ID which is a check the driver made to double check it
was actually talking to the memory mapped space of a TPM.  This patch
removes the check since it isn't absolutely necessary and was causing
device discovery to fail on these machines.

This bug fix should go into 2.6.17.

Signed-off-by: Kylene Hall <kjhall@us.ibm.com>
--- 
 tpm_tis.c |    4 ----
 1 files changed, 4 deletions(-)

--- linux-2.6.17-rc3/drivers/char/tpm/tpm_tis.c	2006-05-16 12:33:36.434356500 -0500
+++ linux-2.6.17-rc3-tpm/drivers/char/tpm/tpm_tis.c	2006-05-25 14:52:01.793058750 -0500
@@ -457,10 +457,6 @@ static int __devinit tpm_tis_pnp_init(st
 	}
 
 	vendor = ioread32(chip->vendor.iobase + TPM_DID_VID(0));
-	if ((vendor & 0xFFFF) == 0xFFFF) {
-		rc = -ENODEV;
-		goto out_err;
-	}
 
 	/* Default timeouts */
 	chip->vendor.timeout_a = msecs_to_jiffies(TIS_SHORT_TIMEOUT);




^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2006-05-25 19:40 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-05-25 19:38 [PATCH] tpm: fix bug for TPM on ThinkPad T60 and Z60 Kylene Jo Hall

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®