From: Arjan van de Ven <arjan@infradead.org>
To: Andrew Morton <akpm@osdl.org>
Cc: Fengguang Wu <wfg@mail.ustc.edu.cn>,
Valdis.Kletnieks@vt.edu, diegocg@gmail.com, lista1@comhem.se,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] readahead: initial method - expected read size - fix fastcall
Date: Sun, 04 Jun 2006 11:25:03 +0200 [thread overview]
Message-ID: <1149413103.3109.90.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <20060604020738.31f43cb0.akpm@osdl.org>
On Sun, 2006-06-04 at 02:07 -0700, Andrew Morton wrote:
> On Sun, 4 Jun 2006 15:34:15 +0800
> Fengguang Wu <wfg@mail.ustc.edu.cn> wrote:
>
> > Remove 'fastcall' directive for function readahead_close().
> >
> > It has drawn concerns from Andrew Morton.
>
> Well. I think fastcall is ugly and vaguely silly. Now if we has a
> really_really_fastcall then I'd like to use that!
>
>
> > Now I have some benchmarks
> > on it, and proved it as a _false_ optimization.
>
> Sorry, I don't believe this will be measurable (and with CONFIG_REGPARM
> it'll be a no-op).
we should just make CONFIG_REGPARM be "it" always (and thus make it go
away as config option) and then just remove all "fastcall" from the
kernel...
next prev parent reply other threads:[~2006-06-04 9:25 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060604073415.GB5405@mail.ustc.edu.cn>
2006-06-04 7:34 ` Fengguang Wu
2006-06-04 9:07 ` Andrew Morton
2006-06-04 9:25 ` Arjan van de Ven [this message]
2006-06-05 1:17 ` Voluspa
2006-06-05 8:00 ` Arjan van de Ven
[not found] ` <20060606022606.GA6071@mail.ustc.edu.cn>
2006-06-06 2:26 ` Fengguang Wu
2006-06-08 7:31 ` Voluspa
[not found] ` <20060608075722.GA5515@mail.ustc.edu.cn>
2006-06-08 7:57 ` Fengguang Wu
[not found] ` <20060606025728.GA6365@mail.ustc.edu.cn>
2006-06-06 2:57 ` Fengguang Wu
2006-06-08 7:43 ` Voluspa
[not found] ` <20060608081352.GB5515@mail.ustc.edu.cn>
2006-06-08 8:13 ` Fengguang Wu
2006-06-08 8:28 ` Voluspa
[not found] ` <20060608085055.GA5917@mail.ustc.edu.cn>
2006-06-08 8:50 ` Fengguang Wu
2006-06-08 10:04 ` Voluspa
[not found] ` <20060604121328.GA6686@mail.ustc.edu.cn>
2006-06-04 12:13 ` [PATCH] readahead: call scheme - fix fastcall readahead_cache_hit() Fengguang Wu
2006-05-30 3:36 Adaptive Readahead V14 - statistics question Voluspa
[not found] ` <20060530064026.GA4950@mail.ustc.edu.cn>
2006-05-30 6:40 ` Wu Fengguang
2006-05-30 16:49 ` Valdis.Kletnieks
2006-05-31 21:06 ` Diego Calleja
2006-05-31 21:50 ` Voluspa
[not found] ` <20060601055143.GA5216@mail.ustc.edu.cn>
2006-06-01 5:51 ` Fengguang Wu
2006-06-01 6:35 ` Voluspa
2006-06-08 8:04 ` Voluspa
[not found] ` <20060608113731.GA5813@mail.ustc.edu.cn>
2006-06-08 11:37 ` adaptive readahead overheads Fengguang Wu
2006-06-08 12:25 ` Voluspa
[not found] ` <20060608123900.GA6885@mail.ustc.edu.cn>
2006-06-08 12:39 ` Fengguang Wu
2006-06-08 13:05 ` Andi Kleen
2006-06-08 14:00 ` Jens Axboe
[not found] ` <448493E9.9030203@samwel.tk>
[not found] ` <20060606033436.GB6071@mail.ustc.edu.cn>
2006-06-06 3:34 ` Adaptive Readahead V14 - statistics question Wu Fengguang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1149413103.3109.90.camel@laptopd505.fenrus.org \
--to=arjan@infradead.org \
--cc=Valdis.Kletnieks@vt.edu \
--cc=akpm@osdl.org \
--cc=diegocg@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lista1@comhem.se \
--cc=wfg@mail.ustc.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®