mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Adam Belay <abelay@novell.com>
Cc: Greg KH <greg@kroah.com>, Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz
Subject: Re: [PATCH 8/9] PCI PM: clear IO and MEM when disabling a device
Date: Tue, 06 Jun 2006 10:32:16 +1000	[thread overview]
Message-ID: <1149553936.559.6.camel@localhost.localdomain> (raw)
In-Reply-To: <1149497176.7831.162.camel@localhost.localdomain>

On Mon, 2006-06-05 at 04:46 -0400, Adam Belay wrote:
> This patch modifies pci_disable_device() to clear IO and MEM from the
> COMMAND PCI config register.  This is required before entering D3,  but
> also probably a good general practice for system suspend.

And will break a great deal of platforms. Don't do it :) The problem is,
I think, mostly related to firmware issues.

Ben.



  parent reply	other threads:[~2006-06-06  0:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-05  8:46 Adam Belay
2006-06-05 16:37 ` Rajesh Shah
2006-06-06  0:32 ` Benjamin Herrenschmidt [this message]
2006-06-07  3:16   ` Adam Belay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1149553936.559.6.camel@localhost.localdomain \
    --to=benh@kernel.crashing.org \
    --cc=abelay@novell.com \
    --cc=akpm@osdl.org \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome